GNOME Bugzilla – Bug 735416
macros2: Remove GNOME_COMMON_INIT
Last modified: 2016-05-13 15:27:47 UTC
Patch coming. I can't find any uses of it in my checked out modules, and it's been deprecated for a while.
Created attachment 284458 [details] [review] macros2: Remove GNOME_COMMON_INIT It’s been deprecated for a while, and apparently no modules (which I have checked out, at least) still use it.
Review of attachment 284458 [details] [review]: Seems fine, but this should probably not be pushed until after the freeze (as I guess this counts as an API change, even though it is unlikely that anything is calling GNOME_COMMON_INIT any more).
(In reply to comment #2) > Review of attachment 284458 [details] [review]: > > Seems fine, but this should probably not be pushed until after the freeze (as I > guess this counts as an API change, even though it is unlikely that anything is > calling GNOME_COMMON_INIT any more). Yeah, sorry, I meant to catch you on IRC to mention that I thought an ideal time to try and get all these changes in would be the start of the next cycle…but I forgot. :-(
(In reply to comment #3) > Yeah, sorry, I meant to catch you on IRC to mention that I thought an ideal > time to try and get all these changes in would be the start of the next > cycle…but I forgot. :-( Not a problem. I was away from IRC all day yesterday (bliss!), so it would have been difficult to find me anyway. :-)
Pushed. Attachment 284458 [details] pushed as 6684e2f - macros2: Remove GNOME_COMMON_INIT
FYI: http://codesearch.debian.net/results/GNOME_COMMON_INIT/page_0 Looks like quite a few 3rd party packages still use that macro
(In reply to Michael Biebl from comment #6) > FYI: http://codesearch.debian.net/results/GNOME_COMMON_INIT/page_0 > > Looks like quite a few 3rd party packages still use that macro I guess they should depend on an older version of gnome-common then. Anything before 3.18.0 should do.
Depending on an older version is not really possible (within) Debian as we can only ship a single version of gnome-common. It means we would have to package gnome-common <= 3.14 as a separate package like say gnome-common-legacy. I'm counting 44 packages in Debian using GNOME_COMMON_INIT and 54 using GNOME_DOC_INIT. Are there migration guides somewhere what packages should do if they want to get rid of those macros?
(In reply to Michael Biebl from comment #8) > Are there migration guides somewhere what packages should do if they want to > get rid of those macros? GNOME_DOC_INIT should be replaced by use of yelp.m4 (YELP_HELP_INIT), and GNOME_COMMON_INIT should simply be removed.
(In reply to David King from comment #9) > (In reply to Michael Biebl from comment #8) > > Are there migration guides somewhere what packages should do if they want to > > get rid of those macros? > > GNOME_DOC_INIT should be replaced by use of yelp.m4 (YELP_HELP_INIT), and > GNOME_COMMON_INIT should simply be removed. Regarding GNOME_DOC_INIT and YELP_INIT: Is this really that simple or do the docs itself need adjustments for yelp? I.e., is YELP_INIT a drop-in replacement for GNOME_DOC_INIT?
See also, https://wiki.gnome.org/Projects/GnomeCommon/Migration.
YELP_INIT can be used a drop-in relacement for GNOME_DOC_INIT (it even works fine for DocBook XML).
Thanks Philip and David. Would be great if you can add the info about GNOME_DOC_INIT/YELP_INIT also to the wiki. This makes it easier to point users/developers at a single place containing all information.
And GNOME_COMMON_INIT isn't listed on the wiki either. A short section that this macro can be removed safely, would be helpful.