After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735401 - make check fails on 3.13.7 without --enable-installed-tests
make check fails on 3.13.7 without --enable-installed-tests
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-08-25 18:24 UTC by Andreas Henriksson
Modified: 2014-08-27 01:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: make reftests work without installed tests (1.70 KB, patch)
2014-08-25 18:41 UTC, Benjamin Otte (Company) 		committed Details | Review

Description Andreas Henriksson 2014-08-25 18:24:27 UTC 
Hello!

When building (debian packages of) gtk+ 3.13.7 I ran into issues like:

** (lt-gtk-reftest:13765): ERROR **: Could not load module 'reftest' from '/tmp/buildd/gtk+3.0-3.13.7/debian/build/shared/testsuite/reftests' when looking up 'reftest:switch_default_direction'
FAIL


(during make check phase I guess)

The problem seemed to be that the generated Makefile didn't even try to build libreftest.la et.al. It had all of those lines commented out. Looking at Makefile.in made me realise this was because the debian packages was built without the "--enable-installed-tests" configure flag.
Adding that worked around the problem.

Running "make check" should probably work even without --enable-installed-tests...
Comment 1 Benjamin Otte (Company) 2014-08-25 18:41:20 UTC 
Created attachment 284443 [details] [review]
build: make reftests work without installed tests

The libreftest.so module needs to be built in all cases.
Without installed tests, it needs to not be installed though.
Comment 2 Matthias Clasen 2014-08-25 22:54:05 UTC 
Review of attachment 284443 [details] [review]:

sure, if it works
Comment 3 Matthias Clasen 2014-08-27 00:06:03 UTC 
Attachment 284443 [details] pushed as 0f0fc59 - build: make reftests work without installed tests
Comment 4 Andreas Henriksson 2014-08-27 01:56:24 UTC 
Additional fixups are needed to actually getting it working.

Company suggested something like: http://ur1.ca/i29mr

Not pretty, but atleast it works.
Comment 5 Andreas Henriksson 2014-08-27 01:57:08 UTC 
(Without the above fix, libtool complains about relative path being used as rpath is not allowed and errors out.)