Created attachment 284283 [details] [review]
Do not depend on gnome-icon-theme

av-cp and universal-cp used to abort when they could not find their icons. I don't know if that's still the case after the UI fiddling.

(In reply to comment #2)
> av-cp and universal-cp used to abort when they could not find their icons. I
> don't know if that's still the case after the UI fiddling.

Fair point - but gnome-ion-themes still no longer exists :)

gupnp-av-cp seems to make references to icons like gtk-execute, which is not part of adwaita-icon-theme...

so there is some more work required - but soon, as 3.14.0 does not come with gnome-icon-themes-* anymore.

Agree, I was just giving an explanation for that check :)

Hm, gtk-execute is the "old" stock id. is this really deprecated?

I think we need to have a deeper look at the icon code.

(In reply to comment #6)
> I think we need to have a deeper look at the icon code.

Checked on what there was in gnome-icon-theme (up to 3.12.0):

src/Makefile.am contained:
        if [ $(ICONMAP) != "false" ]; then \
                cd $(DESTDIR)$(themedir); \
                for size in $(render_sizes); do \
                        cd $$size || continue; \
                        echo -e "Going to set up icon mapping for $$size"; \
                        for dir in `find . -type d`; do \
                                context="`echo $$dir | cut -c 3-`"; \
                                if [ $$context ]; then \
                                        $(ICONMAP) -c $$context; \
                                fi; \
                        done; \
                        cd ..; \
                done; \
        fi



adwaita-icon-theme does not contain any such mapping code - which results in the missing icon compatibility names.

Created attachment 284451 [details] [review]
common: Change icon loading behaviour

Signed-off-by: Jens Georg <mail@jensge.org>

Attachment 284451 [details] pushed as 510c1ca - common: Change icon loading behaviour