GNOME Bugzilla – Bug 735223
Touch scrolling invalidates more than intended
Last modified: 2014-08-28 14:45:00 UTC
Currently when touch scrolling, the scrolled window is a bit too happy at invalidating contents, just in case the overshoot edge gradients kick in or need updating. This was strangely most noticeable to me in wayland, as the performance decrease caused by the constant redraws was quite perceptible. I'm attaching a patch that makes smarter invalidation, both in the invalidated area size and the times it kicks in, this makes touch scrolling snappy in wayland for me.
Created attachment 284217 [details] [review] scrolledwindow: Be smarter at invalidating overshoot areas The previous way to invalidate was meant to work on the overshoot window so it wouldn't be as taxing. Since the overshoot window is gone, this would invalidate way more than intended. So constrain invalidated areas to the sides where overshoot is happenning at that moment.
Created attachment 284320 [details] residue with this patch, I'm seeing a small strip of the overshoot glow remain
Created attachment 284594 [details] [review] scrolledwindow: Be smarter at invalidating overshoot areas The previous way to invalidate was meant to work on the overshoot window so it wouldn't be as taxing. Since the overshoot window is gone, this would invalidate way more than intended. So constrain invalidated areas to the sides where overshoot is happenning at that moment.
Review of attachment 284594 [details] [review]: if you tested that this doesn't leave anything behind, fine with me.
(In reply to comment #4) > Review of attachment 284594 [details] [review]: > > if you tested that this doesn't leave anything behind, fine with me. Yeah, at all angles this time :), I wasn't accounting for the scrollbars' space.
Attachment 284594 [details] pushed as 42c41d7 - scrolledwindow: Be smarter at invalidating overshoot areas