After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734960 - Only remove meta/meta-version.h as part of make distclean
Only remove meta/meta-version.h as part of make distclean
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-17 18:07 UTC by Christophe Fergeau
Modified: 2014-08-18 08:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't list meta/meta-version.h in mutter_built_sources (780 bytes, patch)
2014-08-17 18:07 UTC, Christophe Fergeau 		committed Details | Review
Don't remove meta/meta-version.h during make clean (1.50 KB, patch)
2014-08-17 18:07 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2014-08-17 18:07:48 UTC 
This causes build errors with jhbuild buildone -cfa mutter otherwise.
Comment 1 Christophe Fergeau 2014-08-17 18:07:52 UTC 
Created attachment 283673 [details] [review]
Don't list meta/meta-version.h in mutter_built_sources

It's already listed in libmutterinclude_built_headers.
Comment 2 Christophe Fergeau 2014-08-17 18:07:58 UTC 
Created attachment 283674 [details] [review]
Don't remove meta/meta-version.h during make clean

meta/meta-version.h is generated by configure, so it should be removed
with make distclean, not make clean. This is the heuristic described in
https://www.gnu.org/software/automake/manual/html_node/Clean.html

Cleaning it in make clean means that configure; make clean; make won't
work properly as meta/meta-version.h will be removed and not
regenerated.
Comment 3 Jasper St. Pierre (not reading bugmail) 2014-08-17 18:19:53 UTC 
Review of attachment 283674 [details] [review]:

OK.
Comment 4 Jasper St. Pierre (not reading bugmail) 2014-08-17 18:20:01 UTC 
Review of attachment 283673 [details] [review]:

Sure.
Comment 5 Christophe Fergeau 2014-08-18 08:28:24 UTC 
Attachment 283673 [details] pushed as ec3dc4a - Don't list meta/meta-version.h in mutter_built_sources
Attachment 283674 [details] pushed as 04ddfe0 - Don't remove meta/meta-version.h during make clean