After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734774 - Should not send EOS when draining
Should not send EOS when draining
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
git master
Other Linux
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-14 10:21 UTC by Sebastian Dröge (slomo)
Modified: 2016-07-06 09:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sebastian Dröge (slomo) 2014-08-14 10:21:41 UTC 
+++ This bug was initially created as a clone of Bug #734617 +++

This is for the audio/video decoder/encoder. Currently we forward an EOS event from our srcpad task whenever GstVideo*::finish() is called or GstAudio*::handle_frame(NULL). This is however used for draining.

We should only drain, and then let the EOS event be handled from the streaming thread of the sinkpad (which is no problem as the srcpad streaming thread is not doing anything anymore after draining).
Comment 1 Sebastian Dröge (slomo) 2014-08-14 14:37:13 UTC 
commit d75334456d125bc1d1a3c694ef33e2ce4dd747cf
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Thu Aug 14 17:36:11 2014 +0300

    omx: Let base classes handle EOS
    
    https://bugzilla.gnome.org//show_bug.cgi?id=734774