After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734732 - Do not show down arrow in title box in app mode
Do not show down arrow in title box in app mode
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-13 16:43 UTC by Michael Catanzaro
Modified: 2014-08-13 19:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not show down arrow in title box in app mode (1.56 KB, patch)
2014-08-13 16:43 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-08-13 16:43:35 UTC 
In application mode, the title box is not clickable, so it's wrong to
show a down arrow next to the web address. (The down arrow is used to
indicate that the user can click on the title box.)
Comment 1 Michael Catanzaro 2014-08-13 16:43:37 UTC 
Created attachment 283315 [details] [review]
Do not show down arrow in title box in app mode
Comment 2 Carlos Garcia Campos 2014-08-13 16:58:00 UTC 
Review of attachment 283315 [details] [review]:

::: src/ephy-title-box.c
@@ +497,3 @@
+    uri = g_strdup (label);
+  } else {
+    uri = g_strconcat (rtl ? "▾ " : label, rtl ? label : " ▾", NULL);

You could move the rtl = gtk_widget_get_default_direction () == GTK_TEXT_DIR_RTL; here since the variable is only needed in this branch of the if.
Comment 3 Michael Catanzaro 2014-08-13 19:02:06 UTC 
Good point

Attachment 283315 [details] pushed as a1350e9 - Do not show down arrow in title box in app mode