Created attachment 283224 [details] [review]
AppDisplay: Reset to page 0 on mapped changed

We always want to reset to page 0 on reopening the all view. Currently
we do that only on some cases, like hiding the overview, but not on some
others which is necessary to achieve this. So there were bugs on some of
those cases, since the activePage was not in sync with the current page
that the user is seeing active.

To avoid that, reset to page 0 on mapped property of the main actor of
all view changes.

(In reply to comment #1)
> Created an attachment (id=283224) [details] [review]
> AppDisplay: Reset to page 0 on mapped changed
> 
> We always want to reset to page 0 on reopening the all view. Currently
> we do that only on some cases, like hiding the overview, but not on some
> others which is necessary to achieve this. 

Which are those other cases? Toggling the app picker does reset the page. Pressing ESC does. I cannot think of any other way to exit the app picker so I am not sure what this is supposed to fix.

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=283224) [details] [review] [details] [review]
> > AppDisplay: Reset to page 0 on mapped changed
> > 
> > We always want to reset to page 0 on reopening the all view. Currently
> > we do that only on some cases, like hiding the overview, but not on some
> > others which is necessary to achieve this. 
> 
> Which are those other cases? Toggling the app picker does reset the page.
> Pressing ESC does. I cannot think of any other way to exit the app picker so I
> am not sure what this is supposed to fix.

enter app view, navigate to a page, enter workspace view, enter app view again, try to navigate to a page, it will jump to the previous page + 1.
that's because it's not in sync. See next patch I'll attach to see it better.
In the previous patch I was just making always entering and quiting the allView to reset to page 0 to be consistent (currently changing between frequent view and all view doesn't reset them, since the size of all view is not changing)

Which approach do you like more?

Created attachment 283385 [details] [review]
appDisplay: sync page when changing adjustment

We were setting the value of adjustment on size changes, but we weren't
changing the page value, so adjustment and page value was not in sync.

To fix it, make sure adjustment of the view is in sync with the page
value.

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Created an attachment (id=283224) [details] [review] [details] [review] [details] [review]
> > > AppDisplay: Reset to page 0 on mapped changed
> > > 
> > > We always want to reset to page 0 on reopening the all view. Currently
> > > we do that only on some cases, like hiding the overview, but not on some
> > > others which is necessary to achieve this. 
> > 
> > Which are those other cases? Toggling the app picker does reset the page.
> > Pressing ESC does. I cannot think of any other way to exit the app picker so I
> > am not sure what this is supposed to fix.
> 
> enter app view, navigate to a page, enter workspace view, enter app view again,
> try to navigate to a page, it will jump to the previous page + 1.

Oh ok I can reproduce that.

Review of attachment 283385 [details] [review]:

LG.

Attachment 283385 [details] pushed as d1a3a00 - appDisplay: sync page when changing adjustment