After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734649 - Only notify 'adjustment' if the property changed
Only notify 'adjustment' if the property changed
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkSpinButton
3.13.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-08-12 09:53 UTC by Debarshi Ray
Modified: 2014-08-12 12:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkSpinButton: Only notify 'adjustment' if the property changed (893 bytes, patch)
2014-08-12 09:58 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-08-12 09:53:47 UTC 
We only notify a property when it has actually changed, except in gtk_spin_button_set_adjustment where it emits the notification even if the new adjustment is the same as the old one and nothing changed.
Comment 1 Debarshi Ray 2014-08-12 09:58:06 UTC 
Created attachment 283167 [details] [review]
GtkSpinButton: Only notify 'adjustment' if the property changed
Comment 2 Debarshi Ray 2014-08-12 12:13:23 UTC 
Comment on attachment 283167 [details] [review]
GtkSpinButton: Only notify 'adjustment' if the property changed

Thanks for the review, Benjamin.