GNOME Bugzilla – Bug 734637
gnome-world-3.14: add gnome-flashback
Last modified: 2014-08-13 15:51:27 UTC
Created attachment 283151 [details] [review] gnome-world-3.14: add gnome-flashback Please add new module - gnome-flashback.
Not sure if this is right place to ask, but... Am I allowed to commit these changes directly without creating new bug reports? For example trying to build gnome-applets there is warning: W: gnome-applets has a dependency on unknown "gnome-icon-theme" module Can I simply remove that dependency or should I create new bug report?
I wonder if this is similar to https://mail.gnome.org/archives/release-team/2014-August/msg00018.html and in a set of its own. Not sure though.
gnome-world moduleset already includes GNOME Flashback session related modules - gnome-applets, gnome-panel, meta-gnome-flashback and metacity.
I think it would be less confusing for everybody if alternative sessions get their own files, and we stick to applications in gnome-world
Should I create new moduleset - gnome-flashback-3.14.modules? It could then include meta-gnome-flashback (moved from gnome-world) and gnome-flashback as minimum. But what to do with gnome-panel, metacity and other modules that are only used by this session?
Created attachment 283208 [details] [review] new moduleset - gnome-flashback-3.14
(In reply to comment #4) > I think it would be less confusing for everybody if alternative sessions get > their own files, and we stick to applications in gnome-world On my hand, I won't accept new modulesets in jhbuild (they can be hosted elsewhere where they do not impose me maintenance work), and I consider gnome-world- to be free for all (and I plan to remove the versioned gnome-world-3.x as they are not maintained anyway).
And I just did it. commit d55ce7c0ce275c14b4dbcb149100a20580036637 Author: Frédéric Péters <fpeters@0d.be> Date: Tue Aug 12 17:24:52 2014 +0200 modulesets: remove versioned gnome-world-* Back to gnome-flashback: it may be better to have its own moduleset hosted somewhere. Alberts, see https://mail.gnome.org/archives/release-team/2014-August/msg00025.html for my message on that matter.
(In reply to comment #8) > Back to gnome-flashback: it may be better to have its own moduleset hosted > somewhere. Alberts, see > https://mail.gnome.org/archives/release-team/2014-August/msg00025.html for my > message on that matter. I did read it. :) But still don't understand what should I do now... gnome-world already have meta-gnome-flashback and in future it will depend on gnome-flashback module too. How it will work if gnome-flashback will be hosted somewhere else?
It's just that you can host the gnome-flashback-3.14.modules file you created anywhere, and tell users to use "jhbuild -m https://... build meta-gnome-flashback". jhbuild has code to look into its modulesets when you use <include>, so it will find modules that would be defined in gnome-world.
Changed that include line to: <include href="gnome-world.modules"/> Then I try: jhbuild -m http://{my-ip}/gnome-flashback.modules list But I am getting this error: jhbuild list: failed to parse /home/alberts/.local/lib/python2.7/site-packages/modulesets/gnome-world.modules: [Errno 2] No such file or directory: u'/home/alberts/.local/lib/python2.7/site-packages/modulesets/gnome-world.modules' What I am doing wrong? Would not it be easier to just add that module to gnome-world?
This is probably because the installation you have in ~/.local/ predates my change from gnome-world-3.14.modules to gnome-world.modules.
(In reply to comment #12) > This is probably because the installation you have in ~/.local/ predates my > change from gnome-world-3.14.modules to gnome-world.modules. Similar error if i try to include gnome-apps-3.14.modules...
About missing 'gnome-icon-theme' module. I found this commit: https://git.gnome.org/browse/jhbuild/commit/?id=ecaa0f734e01d7d69b98b0242ee85645ce1f47b3 gnome-icon-theme was removed from 'gnome-suites-core-3.14.modules' and added to 'gnome-world-3.12.modules'. Is that mistake? Why it was added to 3.12 not 3.14?
In 3.14 gnome-icon-theme changed name and became adwaita-icon-theme; to keep 3.12 building the module was added back to 3.12, as a checkout of the gnome-3-12 branch of adwaita-icon-theme (to get the gnome-icon-theme.pc file).
If I remove include line from *.modules file then trying to build gnome-flashback I am getting warnings about unknown modules. Can you please add that module to gnome-world?
I'd tell you to go for it and add it to gnome-world, I really don't care much about that moduleset. (but I tested the include line and it worked fine, not sure what's wrong).
(In reply to comment #17) > I'd tell you to go for it and add it to gnome-world, I really don't care much > about that moduleset. (but I tested the include line and it worked fine, not > sure what's wrong). Thanks! I added it to gnome-world. Could you show your moduleset file that you used for testing? I will test it to see if there is something wrong with my jhbuild install or my moduleset file.
Created attachment 283298 [details] [review] gnome-world: add gnome-flashback