GNOME Bugzilla – Bug 734623
facedetect: fix NULL error when disable eyes/nose/mouth
Last modified: 2014-08-13 15:33:32 UTC
Created attachment 283121 [details] [review] disable eyes/nose/mouth recognition With that patch, we can now disable the eyes/nose/mouth recognition by setting their profiles to NULL. # Example - To enable the nose recognition : #define DEFAULT_NOSE_PROFILE HAAR_CASCADES_DIR "haarcascade_mcs_nose.xml" - To disable it : #define DEFAULT_NOSE_PROFILE NULL
Could you please submit the patch with git format-patch format? This format doesn't apply with git.
Created attachment 283128 [details] [review] patch with git format
Review of attachment 283128 [details] [review]: I would prefer this to be handled directly in the _load_profile function. Just check for NULL there and return NULL in that case. Additionally your patch seems to be agains gstfacedetect_orig.c, not against gstfacedetect.c
Created attachment 283132 [details] [review] follows thiagoss advices
Comment on attachment 283132 [details] [review] follows thiagoss advices Please attach this in "git format-patch" format with a commit message, your name and mail address
Created attachment 283293 [details] [review] complete git format-patch
Thanks for the patch, but please notice how gstreamer developers use the commit message, as I fixed that below. commit 03b70aecec02b417cc67c88639a05f771acdc317 Author: Valentin PONS <valx76@gmail.com> Date: Wed Aug 13 16:57:15 2014 +0200 facedetect: Use NULL to disable eyes/nose/mouth Without printing a warning about it https://bugzilla.gnome.org/show_bug.cgi?id=734623 Put something like: elementname: short description long description (bug number, if available)
Comment on attachment 283293 [details] [review] complete git format-patch with an improved commit message