GNOME Bugzilla – Bug 734614
Undo buttons in application notifications are too tall
Last modified: 2014-08-13 17:58:47 UTC
Created attachment 283100 [details] Screenshot of gnome-boxes The "undo" button in the screenshot is too tall. I think this is a regression due to the Adwaita re-write because I can not find any Boxes specific style class in the code, and building against gtk-3.12 gives us a nice margin around the button. The notification bar uses the "app-notification" style class.
The in app notification didn't get much love, I'll tale a look, it would be nice to have a such a button in the widget factory tho
Created attachment 283144 [details] [review] widget-factory: Turn off focus-on-click for notification close button
Created attachment 283145 [details] [review] widget-factory: Add a reset button to the notification
(In reply to comment #1) > The in app notification didn't get much love, I'll tale a look, it would be > nice to have a such a button in the widget factory tho There you go. This makes me realize that the widget-factory and applications (Boxes, Documents and Photos) are constructing the in-app notifications in slightly different ways. Particularly, in this case, the widget-factory sets a margin of 10 on all sides while the applications were only specifying left and right margins. Given that these libgd applications themselves differ in their use of GdNotification, I wonder if we should try to standardize this some more. eg., in Boxes each notification is a GdNotification, while the others use GdNotification as a floating container in which the individual notification labels and buttons are packed.
Review of attachment 283144 [details] [review]: sure
Review of attachment 283145 [details] [review]: if setting it to 42 pops up the notification again right away, it might be better to use a different initial value
Created attachment 283146 [details] [review] widget-factory: Add a reset button to the notification Use 50 as an initial value instead of 42. 50 is not a multiple of 3, and it is being used in adjustment1.
From #gtk+ on GIMPNet: 21:44 <rishi> mclasen: Changed it to 50. 21:44 <mclasen> feel free to push it with that change