After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734548 - avoid removing non-existent GSource
avoid removing non-existent GSource
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-09 13:12 UTC by Ondrej Holy
Modified: 2014-08-14 11:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
avoid removing non-existent GSources (1.76 KB, patch)
2014-08-09 13:17 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2014-08-09 13:12:01 UTC 
Critical warnings are shown in the Add user dialog, when user is filling name/username/password/domain entry:

(gnome-control-center:16319): GLib-CRITICAL **: Source ID 2619 was not found when attempting to remove it

because non-existent GSources are removed.
Comment 1 Ondrej Holy 2014-08-09 13:17:19 UTC 
Created attachment 283002 [details] [review]
avoid removing non-existent GSources

Source id have to be zeroed correctly.
Comment 2 Bastien Nocera 2014-08-09 15:26:47 UTC 
Review of attachment 283002 [details] [review]:

Correct
Comment 3 Ondrej Holy 2014-08-14 11:52:40 UTC 
Comment on attachment 283002 [details] [review]
avoid removing non-existent GSources

commit 0f3575b3179a224acfbe59576ac9013d0af10061