After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734538 - tests: Avoid leaking caps object in colorspace tests
tests: Avoid leaking caps object in colorspace tests
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal minor
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-09 12:02 UTC by Sebastian Rasmussen
Modified: 2014-08-10 11:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (2.29 KB, patch)
2014-08-09 12:03 UTC, Sebastian Rasmussen 		rejected Details | Review

Description Sebastian Rasmussen 2014-08-09 12:02:33 UTC 
There are caps objects being leaked in the colorspace tests when calling gst_pad_get_pad_template_caps(). The attached patch fixes these problems.
Comment 1 Sebastian Rasmussen 2014-08-09 12:03:13 UTC 
Created attachment 282993 [details] [review]
Proposed patch.
Comment 2 Tim-Philipp Müller 2014-08-10 11:33:20 UTC 
I'm going to WONTFIX this too. This test is no longer functional, since it uses 0.10 elements and video caps and the colorspace element has been removed (or is now videoconvert).

In future, please make sure to mention when you submit patches blindly without actually having tested/run them (goes for all other patches too).

commit 64f92ce6280af6455bf8e325ad587cd47f04a43d
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Sun Aug 10 11:35:41 2014 +0100

    tests: remove defunct test code for old colorspace element
    
    https://bugzilla.gnome.org/show_bug.cgi?id=734538