After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734537 - pvrvideosink: Avoid leaking bufferpool configuration
pvrvideosink: Avoid leaking bufferpool configuration
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.4.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-09 12:00 UTC by Sebastian Rasmussen
Modified: 2014-08-11 06:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (1.09 KB, patch)
2014-08-09 12:01 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-09 12:00:40 UTC 
gst_buffer_pool_get_config() returns a reference to the bufferpool's configuration, which must be passed to gst_structure_free() after use. The attached patch fixes this omission.
Comment 1 Sebastian Rasmussen 2014-08-09 12:01:19 UTC 
Created attachment 282992 [details] [review]
Proposed patch.
Comment 2 Tim-Philipp Müller 2014-08-10 11:23:32 UTC 
commit 078958bd6bb6f5de1a8e57d434d691f5e7827134
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sat Aug 9 13:24:00 2014 +0200

    pvrvideosink: Avoid leaking bufferpool configuration
    
    gst_buffer_pool_get_config() returns a copy to the bufferpool's
    configuration, which must be passed to gst_structure_free() after
    use if not given away to gst_buffer_pool_set_config().
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734537