After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734435 - rtph263ppay: Unref pad template caps after use
rtph263ppay: Unref pad template caps after use
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.4.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-07 14:37 UTC by Sebastian Rasmussen
Modified: 2014-08-08 19:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch fixing leak. (1.12 KB, patch)
2014-08-07 14:38 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-08-07 14:37:17 UTC 
There are many places where gst_pad_get_pad_template_caps() returns a referenced caps that is not unreffed. This is one of them and the attached patch aims to fix the leak.
Comment 1 Sebastian Rasmussen 2014-08-07 14:38:03 UTC 
Created attachment 282819 [details] [review]
Proposed patch fixing leak.
Comment 2 Thiago Sousa Santos 2014-08-08 19:18:46 UTC 
master:

commit 276269d956723ddc342c4de175f71a7fc9fc54b5
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Thu Aug 7 16:34:36 2014 +0200

    rtph263ppay: Unref pad template caps after use
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734435

1.4:
commit 86cba0fcaa465b233097e287e8c38e8d9587809a
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Thu Aug 7 16:34:36 2014 +0200

    rtph263ppay: Unref pad template caps after use
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734435