GNOME Bugzilla – Bug 734078
Use Champlains support for Kinetic mode.
Last modified: 2014-08-11 19:59:51 UTC
Dario stumbled over this property here at GUADEC. It makes Maps behave like other map clients when it comes to panning. Really smooth. There was a concensus at the bof that this was something we wanted.
Created attachment 282204 [details] [review] MapView: use properties directly We tend to want to use the gjs property directly instead of running the get-/set-wrappers. Make MapView only use properties.
Created attachment 282205 [details] [review] MapView: Use kinetic mode With kinetic mode turned on Maps panning in Maps feels much much smoother. Thanks to Dario who stumbled over this property.
Review of attachment 282205 [details] [review]: While we definitely want this, we need to first talk to Jiri about why this is not the default.
(In reply to comment #3) > Review of attachment 282205 [details] [review]: > > While we definitely want this, we need to first talk to Jiri about why this is > not the default. Hm, ok. Could you do that then and report here afterwards?
(In reply to comment #3) > Review of attachment 282205 [details] [review]: > > While we definitely want this, we need to first talk to Jiri about why this is > not the default. The only reason is the backwards compatibility - it was always off by default. But it's not some experimental feature, it should definitely work (all of the more advanced libchamplain demos have it enabled). I was actually wondering why it wasn't enabled in Maps - I thought you had some reasons for it (one could be that if you have a really slow GPU, the animation won't look nice).
Attachment 282205 [details] pushed as ae15a1a - MapView: Use kinetic mode Thx, pushed! @282204 - MapView: use properties directly - none Thx pushed! @282205 - MapView: Use kinetic mode - none
Isn't already enabled by default or am I really confused? I remember that the deaceleration worked fine in 3.10 and 3.12. https://developer.gnome.org/libchamplain/unstable/ChamplainView.html#ChamplainView--kinetic-mode https://git.gnome.org/browse/libchamplain/tree/champlain/champlain-view.c#n833 https://git.gnome.org/browse/libchamplain/tree/champlain/champlain-view.c#n1118
(In reply to comment #7) > Isn't already enabled by default or am I really confused? I remember that the > deaceleration worked fine in 3.10 and 3.12. > > https://developer.gnome.org/libchamplain/unstable/ChamplainView.html#ChamplainView--kinetic-mode > > https://git.gnome.org/browse/libchamplain/tree/champlain/champlain-view.c#n833 > > https://git.gnome.org/browse/libchamplain/tree/champlain/champlain-view.c#n1118 Same here. When in comment#5 Jiri explained why its not the default, I assumed (and so did others I guess) that it really is not the default but code does not lie. :)
Hm, after some investigation it's like this - it was FALSE originally, then in 3a3b7b0dd0ec2ce09e8ac4bb2e95d25860b6c4c4 2013-05-02 11:02:38 I changed it to TRUE (really don't remember why, I was fixing some zooming animations and it's possible I just set it to TRUE for testing for some reason and forgot about it). However, just by itself, setting the property to TRUE doesn't turn the kinetic mode on - you have to change the corresponding property of kinetic_scroll (see champlain_view_set_kinetic_mode()). So even though it was set to TRUE, it behaved as if it was FALSE. I suggest to keep the default to FALSE so the behavior remains the same as before (but of course change the default value, the current state is completely misleading). I don't have an explanation why in previous versions of Maps kinetic mode worked but I think the only possible way was the property was manually set somewhere - as far as I can tell the libchamplain *behavior* (not the actual property value) was always without kinetic mode by default.