After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733910 - Removing the separator from the HeaderBar
Removing the separator from the HeaderBar
Status: RESOLVED DUPLICATE of bug 729636
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-07-29 09:58 UTC by Gianluca Sartori
Modified: 2014-08-28 10:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Preferences Dialog (69.25 KB, image/png)
2014-07-29 09:59 UTC, Gianluca Sartori
Details
Weather (290.57 KB, image/png)
2014-07-29 09:59 UTC, Gianluca Sartori
Details
Web (102.51 KB, image/png)
2014-07-29 10:00 UTC, Gianluca Sartori
Details
File (128.98 KB, image/png)
2014-07-29 10:00 UTC, Gianluca Sartori
Details
Headerbar close window button spacing (263.51 KB, image/png)
2014-08-28 10:40 UTC, Gianluca Sartori
Details

Description Gianluca Sartori 2014-07-29 09:58:40 UTC
I'd like to discuss the purpose of the separator you can find at the left of the "Close Window" button (the X icon).

The header bar buttons are rendered as "normal" buttons with borders while the X is just a symbol with no borders until the user hover the mouse on it. It does make sense given the very specific role of the X symbol/button: it's a fundamental component of every window, while the buttons they change for every application.

I find the separator to be redundant, it looks like it's there just to please the user eyes, but at same time it dirties the header bar (which by the way It's amazingly designed, I love it)

I'm attaching some mock-ups without the separator to have a quick impression on the result.
Comment 1 Gianluca Sartori 2014-07-29 09:59:23 UTC
Created attachment 281929 [details]
Preferences Dialog
Comment 2 Gianluca Sartori 2014-07-29 09:59:49 UTC
Created attachment 281930 [details]
Weather
Comment 3 Gianluca Sartori 2014-07-29 10:00:15 UTC
Created attachment 281931 [details]
Web
Comment 4 Gianluca Sartori 2014-07-29 10:00:35 UTC
Created attachment 281932 [details]
File
Comment 5 Matthias Clasen 2014-07-30 20:57:48 UTC

*** This bug has been marked as a duplicate of bug 729636 ***
Comment 6 Gianluca Sartori 2014-07-31 09:34:07 UTC
My request was really intended to completely drop the separator, the  bug 729636 has a different purpose of deciding wether to show it or not depending on different scenarios.

I'm stating here that the separator is not needed by a design point of view, it's redundant, it doesn't solve a real problem: the separation between the "closing" function and the header bar buttons is made clear by the different behaviour/rendering of the X button.

In the mochups I provided you can have a feeling of it.
Comment 7 Lapo Calamandrei 2014-07-31 22:37:24 UTC
Not a duplicate to me as well, I was thinking about hiding it in adwaita anyway, let's keep the two bugs separate, I'll do some tests in the meantime.
Comment 8 Jakub Steiner 2014-08-01 12:35:16 UTC
I agree with the suggested notion that the non-raised style of the window close button alone provides enough visual separation for the explicit separator line to be redundant.
Comment 9 Matthias Clasen 2014-08-01 13:36:02 UTC
I dont. And please accept that as the sole person wrangling over 3000 open gtk bugs, I'll mark bugs as duplicates as I see fit.

*** This bug has been marked as a duplicate of bug 729636 ***
Comment 10 Gianluca Sartori 2014-08-28 10:40:20 UTC
I had a look at the implementation (I'm testing the continuous releases now). 

A more appropriate space between the headerbar icons and the "close window" button should be 6 pixels (now it's 12) so that there is continuity with the other buttons when the "close window" button is hovered.

I'm attaching a mockup to highlight the issue.
Comment 11 Gianluca Sartori 2014-08-28 10:40:57 UTC
Created attachment 284674 [details]
Headerbar close window button spacing