After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733816 - Ctrl+n does not work
Ctrl+n does not work
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other Linux
: Low minor
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-27 11:56 UTC by Lasse Schuirmann
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
app-window: Add Ctrl+N shortcut (1.93 KB, patch)
2014-08-15 20:06 UTC, Lasse Schuirmann 		needs-work Details | Review
collection-toolbar: Move public functions up (1.32 KB, patch)
2014-08-15 20:06 UTC, Lasse Schuirmann 		needs-work Details | Review
collection-toolbar: Move public functions up (1.16 KB, patch)
2014-08-16 17:49 UTC, Lasse Schuirmann 		committed Details | Review
app-window: Add Ctrl+N shortcut (2.02 KB, patch)
2014-08-16 17:49 UTC, Lasse Schuirmann 		committed Details | Review

Description Lasse Schuirmann 2014-07-27 11:56:25 UTC 
Ctrl+n should click the new button.

I'm making this dependent on the code refactorings to avoid unneeded merges.
Comment 1 Zeeshan Ali 2014-07-28 10:00:07 UTC 
The accelerator is available through Alt so Alt+N achieves that.
Comment 2 Lasse Schuirmann 2014-07-28 10:21:09 UTC 
yes thats the mnemonic. But usually every application supports Ctrl+N for creating new things, users are therefore accustomed to it and use it intuitively. (At least I do...)
Comment 3 Lasse Schuirmann 2014-08-15 20:06:20 UTC 
Created attachment 283567 [details] [review]
app-window: Add Ctrl+N shortcut
Comment 4 Lasse Schuirmann 2014-08-15 20:06:24 UTC 
Created attachment 283568 [details] [review]
collection-toolbar: Move public functions up
Comment 5 Zeeshan Ali 2014-08-16 17:42:19 UTC 
Review of attachment 283567 [details] [review]:

Some indication in the log about what ctrl+n does would be nice. :)
Comment 6 Lasse Schuirmann 2014-08-16 17:43:26 UTC 
Review of attachment 283567 [details] [review]:

isnt that a 'common abbreviation'? ;) I'll reupload in some minutes.
Comment 7 Zeeshan Ali 2014-08-16 17:44:21 UTC 
Review of attachment 283568 [details] [review]:

if you move this patch up (before the other one), it will be smaller change as you can merge the click_new_button change into the other patch. :)
Comment 8 Zeeshan Ali 2014-08-16 17:46:47 UTC 
Review of attachment 283567 [details] [review]:

"isnt that a 'common abbreviation'? ;)"

abbreviation -> shortcut and even if its common, doesn't mean everyone knows about it. At least I didn't know its supported by everything. :)
Comment 9 Lasse Schuirmann 2014-08-16 17:49:15 UTC 
Created attachment 283609 [details] [review]
collection-toolbar: Move public functions up
Comment 10 Lasse Schuirmann 2014-08-16 17:49:19 UTC 
Created attachment 283610 [details] [review]
app-window: Add Ctrl+N shortcut

Ctrl+N is a common shortcut for creating new things. Lets support it for
creating a new VM.
Comment 11 Zeeshan Ali 2014-08-16 17:53:21 UTC 
Attachment 283609 [details] pushed as cdef60b - collection-toolbar: Move public functions up
Attachment 283610 [details] pushed as 433c8af - app-window: Add Ctrl+N shortcut