After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733731 - stock icons missing: gtk-update-icon-cache missing args?
stock icons missing: gtk-update-icon-cache missing args?
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: [obsolete] stock-icons
3.12.x
Other OpenBSD
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-07-25 11:42 UTC by Antoine Jacoutot
Modified: 2014-10-02 20:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
include stock icons images (809 bytes, patch)
2014-07-31 15:00 UTC, Antoine Jacoutot
none Details | Review

Description Antoine Jacoutot 2014-07-25 11:42:32 UTC
Hi.

There seems to be a difference in behavior in gtk-update-icon-cache when it is compiled as part of gtk+2 instead of gtk+3.
I am currently compiling gtk+3 with:
--enable-gtk2-dependency
to use gtk-update-icon-cache from gtk+2.

However, doing so I am loosing some stock icons:

(anjuta:7116): GLib-GIO-CRITICAL **: g_loadable_icon_load: assertion 'G_IS_LOADABLE_ICON (icon)' failed
(anjuta:7116): Gtk-WARNING **: Error loading theme icon 'gtk-edit' for stock: Failed to load icon
(anjuta:7116): Gtk-CRITICAL **: render_fallback_image: assertion 'pixbuf != NULL' failed
(anjuta:7116): GLib-GObject-CRITICAL **: g_object_ref: assertion 'G_IS_OBJECT (object)' failed

It works fine if I do not pass --enable-gtk2-dependency (so that gtk-update-icon-cache comes from gtk+3).

I found a way to make it work though, by adding:
--include-image-data
to the gtk-update-icon-cache call in gtk/Makefile (which is what gtk+2 does).

I did not look as to why this flags is not needed for the gtk+3 version of gtk-update-icon-cache; but something should be done so that it works whether --enable-gtk2-dependency was passed or not to the gtk+3 compilation.

Thanks.
Comment 1 Matthias Clasen 2014-07-25 17:38:33 UTC
Which version is this with ?
Current gtk3 does not use gtk-update-icon-cache at build time anymore.
Comment 2 Antoine Jacoutot 2014-07-25 17:41:33 UTC
Sorry, 3.12.2.
Comment 3 Antoine Jacoutot 2014-07-31 15:00:37 UTC
Created attachment 282151 [details] [review]
include stock icons images

Hi Matthias.

FWIW here's the current patch that I am using.
Comment 4 Pacho Ramos 2014-08-02 10:08:29 UTC
Looks to also affect to others:
https://bugs.gentoo.org/show_bug.cgi?id=518352
Comment 5 Antoine Jacoutot 2014-10-02 13:26:13 UTC
Closing. This became obsolete after 36be12578ca252d3f48ead0d2bfaba6b09b8dd60.
Comment 6 Leho Kraav (@lkraav :macmaN) 2014-10-02 20:06:29 UTC
What version is this included in? It's difficult decipher that info from https://git.gnome.org/browse/gtk+/commit/?id=36be12578ca252d3f48ead0d2bfaba6b09b8dd60
Comment 7 Antoine Jacoutot 2014-10-02 20:09:09 UTC
(In reply to comment #6)
> What version is this included in? It's difficult decipher that info from
> https://git.gnome.org/browse/gtk+/commit/?id=36be12578ca252d3f48ead0d2bfaba6b09b8dd60

3.14.0 and up