After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733662 - No accessible focused-changed signals emitted when Tabbing amongst form fields
No accessible focused-changed signals emitted when Tabbing amongst form fields
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-24 11:58 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2014-07-24 15:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (6.34 KB, patch)
2014-07-24 11:58 UTC, Joanmarie Diggs (IRC: joanie) 		reviewed Details | Review
proposed patch (6.07 KB, patch)
2014-07-24 14:33 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2014-07-24 11:58:52 UTC 
Created attachment 281573 [details] [review]
proposed patch

Form fields are now Tab-focusable, but the expected accessible events are missing. These events are needed for Orca to present the newly focused object and gnome-shell magnifier to ensure it is visible on screen.
Comment 1 Carlos Garcia Campos 2014-07-24 13:01:46 UTC 
Review of attachment 281573 [details] [review]:

Looks good, except for the g_clear_object of the focused element.

::: libview/ev-view-accessible.c
@@ +115,2 @@
 	clear_children (EV_VIEW_ACCESSIBLE (object));
+	g_clear_object(&priv->focused_element);

You are not taking a reference of this object no?
Comment 2 Joanmarie Diggs (IRC: joanie) 2014-07-24 14:33:36 UTC 
Created attachment 281599 [details] [review]
proposed patch

Removed the call to g_clear_object()
Comment 3 Carlos Garcia Campos 2014-07-24 14:46:05 UTC 
Review of attachment 281599 [details] [review]:

Ok
Comment 4 Joanmarie Diggs (IRC: joanie) 2014-07-24 15:28:17 UTC 
Comment on attachment 281599 [details] [review]
proposed patch

https://git.gnome.org/browse/evince/commit/?id=8246fa2