After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733636 - grilo: Do not free GrlRegistry
grilo: Do not free GrlRegistry
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
unspecified
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-23 22:42 UTC by Juan A. Suarez Romero
Modified: 2014-08-03 07:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
grilo: Do not free GrlRegistry (788 bytes, patch)
2014-07-23 22:42 UTC, Juan A. Suarez Romero 		committed Details | Review

Description Juan A. Suarez Romero 2014-07-23 22:42:39 UTC 
Registry returned by Grilo is freed in Grilo plugin (impl_deactivate). But it is actually a singleton that shouldn't be freed.
Comment 1 Juan A. Suarez Romero 2014-07-23 22:42:41 UTC 
Created attachment 281538 [details] [review]
grilo: Do not free GrlRegistry

It is a singleton.
Comment 2 Jonathan Matthew 2014-08-03 07:03:29 UTC 
pushed to master.  thanks for the patch.