After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733588 - videobox: Add format conversion gray to/from AYUV/RGB
videobox: Add format conversion gray to/from AYUV/RGB
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-23 06:16 UTC by RaviKiran
Modified: 2014-09-24 07:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
AYUV <-> GRAY conversion (8.26 KB, patch)
2014-07-23 06:18 UTC, RaviKiran 		none Details | Review
GRAY8 <-> GRAY16 conversion (3.80 KB, patch)
2014-07-23 06:18 UTC, RaviKiran 		none Details | Review
RGB <-> GRAY conversion (8.78 KB, patch)
2014-07-23 06:19 UTC, RaviKiran 		none Details | Review
Unit tests for supported conversions (2.52 KB, patch)
2014-07-23 06:20 UTC, RaviKiran 		none Details | Review

Description RaviKiran 2014-07-23 06:16:39 UTC 
Currently, videobox supports below format conversions
I420->AYUV
I420->YV12
YV12->AYUV
YV12->I420
AYUV->I420
AYUV->YV12
AYUV->xRGB (24bpp, 32bpp, incl. alpha)
xRGB->xRGB (24bpp, 32bpp, from/to all variants, incl. alpha)
xRGB->AYUV (24bpp, 32bpp, incl. alpha)

RGB/YUV to GRAY and vice-versa isn't supported, although videobox can work with GRAY format

pipelines like below will work without converter if gray conversion is supported.
gst-launch-1.0 videotestsrc ! "video/x-raw,format={GRAY8}" ! videobox ! ximagesink
Comment 1 RaviKiran 2014-07-23 06:18:13 UTC 
Created attachment 281452 [details] [review]
AYUV <-> GRAY conversion
Comment 2 RaviKiran 2014-07-23 06:18:49 UTC 
Created attachment 281453 [details] [review]
GRAY8 <-> GRAY16 conversion
Comment 3 RaviKiran 2014-07-23 06:19:25 UTC 
Created attachment 281454 [details] [review]
RGB <-> GRAY conversion
Comment 4 RaviKiran 2014-07-23 06:20:08 UTC 
Created attachment 281455 [details] [review]
Unit tests for supported conversions

Patches for proposed changes attached.
Comment 5 Luis de Bethencourt 2014-09-18 14:39:59 UTC 
Looks good.

Could you tell me how to test this fully before I go ahead and merge it?
Comment 6 Sebastian Dröge (slomo) 2014-09-23 20:19:24 UTC 
I don't think we should add more format conversions to videobox... having any at all there already was not very clever. If anything we should use the code from videoconvert in here instead of reimplementing it.
Comment 7 Sebastian Dröge (slomo) 2014-09-23 20:25:26 UTC 
See bug #732415
Comment 8 RaviKiran 2014-09-24 03:49:09 UTC 
Yes, I later learnt about videoscale and videoconvert API enhancement.
Comment 9 Sebastian Dröge (slomo) 2014-09-24 06:32:26 UTC 
A patch that changes the conversion code in videobox to use those would be nice though, if you want to work on that :)
Comment 10 RaviKiran 2014-09-24 07:10:58 UTC 
Sure. :)