After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733579 - pull-local: Write detached metadata into the correct repository
pull-local: Write detached metadata into the correct repository
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-22 19:43 UTC by Colin Walters
Modified: 2014-07-22 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pull-local: Write detached metadata into the correct repository (1.63 KB, patch)
2014-07-22 19:43 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2014-07-22 19:43:32 UTC 
We want to write to the dest repo, not src.

Noticed while reviewing this code for some other bug.
Comment 1 Colin Walters 2014-07-22 19:43:33 UTC 
Created attachment 281436 [details] [review]
pull-local: Write detached metadata into the correct repository
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-07-22 20:22:25 UTC 
Review of attachment 281436 [details] [review]:

Duh.

I sort of wonder if we should have an open-read-only flag to catch stuff like this, so that any write will fail.
Comment 3 Colin Walters 2014-07-22 20:38:51 UTC 
Attachment 281436 [details] pushed as 9bd229d - pull-local: Write detached metadata into the correct repository