After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733560 - Touch events trigger enter events on press, but no leave events on release
Touch events trigger enter events on press, but no leave events on release
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-22 13:48 UTC by Carlos Garnacho
Modified: 2014-07-23 12:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
input-device: Ensure crossing events are paired for touch sequences (1.03 KB, patch)
2014-07-22 13:49 UTC, Carlos Garnacho
committed Details | Review

Description Carlos Garnacho 2014-07-22 13:48:29 UTC
when a CLUTTER_TOUCH_BEGIN is gotten, the actor is set for the sequence, which does trigger a CLUTTER_ENTER event, crossing events are also sent when the touch drifts across actors, but when CLUTTER_TOUCH_END is gotten, there is no attempt to unset the actor nor send the final CLUTTER_LEAVE event for the device, which leaves "prelighted" actors, if those do react to crossing events.

I'm attaching a patch to fix that.
Comment 1 Carlos Garnacho 2014-07-22 13:49:34 UTC
Created attachment 281384 [details] [review]
input-device: Ensure crossing events are paired for touch sequences

When the sequence is lifted the actor wouldn't be unset, so the corresponding
CLUTTER_LEAVE event would never be sent for the touch sequence.
Comment 2 Emmanuele Bassi (:ebassi) 2014-07-22 16:32:23 UTC
Review of attachment 281384 [details] [review]:

looks good.
Comment 3 Carlos Garnacho 2014-07-23 12:33:22 UTC
Attachment 281384 [details] pushed as 0c0c069 - input-device: Ensure crossing events are paired for touch sequences