After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733521 - [Patch] Tweaks to help other games to look good.
[Patch] Tweaks to help other games to look good.
Status: RESOLVED FIXED
Product: iagno
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: iagno-maint
iagno-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-21 20:55 UTC by Arnaud B.
Modified: 2014-07-22 20:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Tweaks to help other games to look good. (2.17 KB, patch)
2014-07-21 20:55 UTC, Arnaud B. 		needs-work Details | Review
current master (including your previous patch) (16.51 KB, image/png)
2014-07-22 02:18 UTC, Michael Catanzaro 		  Details
screenshot with this patch applied (button too close to board) (16.56 KB, image/png)
2014-07-22 02:19 UTC, Michael Catanzaro 		  Details
Tweaks to help other games to look good. (2.20 KB, patch)
2014-07-22 16:24 UTC, Arnaud B. 		committed Details | Review

Description Arnaud B. 2014-07-21 20:55:29 UTC 
Created attachment 281347 [details] [review]
Tweaks to help other games to look good.

I’ve previously made a patch to ensure Iagno always looks good [1], but it would be great to use a way to do this that all games could copy. Here is a patch for that, verified with gnome-sudoku [2] (with some changes just proposed here [3]).

[1] https://bugzilla.gnome.org/show_bug.cgi?id=733502
[2] http://pix.toile-libre.org/upload/original/1405974637.png
[3] https://bugzilla.gnome.org/show_bug.cgi?id=733520
Comment 1 Michael Catanzaro 2014-07-22 02:17:31 UTC 
Review of attachment 281347 [details] [review]:

Arnaud, thanks again for your patch. I really appreciate your work to improve our window layouts. I was a bit frustrated with this myself yesterday.

This patch doesn't work very well for me when the window size is small; could you try to fix this?
Comment 2 Michael Catanzaro 2014-07-22 02:18:17 UTC 
Created attachment 281355 [details]
current master (including your previous patch)
Comment 3 Michael Catanzaro 2014-07-22 02:19:20 UTC 
Created attachment 281356 [details]
screenshot with this patch applied (button too close to board)
Comment 4 Arnaud B. 2014-07-22 16:24:20 UTC 
Created attachment 281401 [details] [review]
Tweaks to help other games to look good.
Comment 5 Michael Catanzaro 2014-07-22 20:33:38 UTC 
Review of attachment 281401 [details] [review]:

Looks good, committing with this change:

::: src/iagno.vala
@@ +135,3 @@
         var hbox = new Gtk.Box (Gtk.Orientation.HORIZONTAL, 0);
+        hbox.halign = Gtk.Align.FILL;
+        hbox.spacing = 25;

This should be set in the constructor (it's the second parameter)