After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733417 - Fixes for HiDPi support
Fixes for HiDPi support
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 733416
Blocks:
 
 
Reported: 2014-07-19 20:11 UTC by Cosimo Cecchi
Modified: 2014-07-23 03:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
info: use resource instead of pixbuf to load SVG (1.17 KB, patch)
2014-07-19 20:11 UTC, Cosimo Cecchi 		committed Details | Review
mouse: use resource instead of pixbuf to load SVG (1.15 KB, patch)
2014-07-19 20:11 UTC, Cosimo Cecchi 		committed Details | Review
background: render the preview top bar with scale factor (1.79 KB, patch)
2014-07-20 04:11 UTC, Cosimo Cecchi 		rejected Details | Review

Description Cosimo Cecchi 2014-07-19 20:11:41 UTC 
Some SVG assets in the panels are not rendered with the correct scale factor; the GNOME logo in the Details panel and the test area background in the Mouse and Touchpad panel.
Needs https://bugzilla.gnome.org/show_bug.cgi?id=733416 to actually work, but the patches could go in without that too (with no change in functionality)
Comment 1 Cosimo Cecchi 2014-07-19 20:11:44 UTC 
Created attachment 281201 [details] [review]
info: use resource instead of pixbuf to load SVG

This will let us load the image with appropriate scale factor when
necessary.
Comment 2 Cosimo Cecchi 2014-07-19 20:11:49 UTC 
Created attachment 281202 [details] [review]
mouse: use resource instead of pixbuf to load SVG

This will let us load the image with appropriate scale factor when
necessary.
Comment 3 Cosimo Cecchi 2014-07-20 04:11:13 UTC 
Created attachment 281219 [details] [review]
background: render the preview top bar with scale factor

Otherwise on hi-dpi only the top left quarter will be rendered.
Comment 4 Bastien Nocera 2014-07-21 10:45:25 UTC 
Review of attachment 281201 [details] [review]:

++
Comment 5 Bastien Nocera 2014-07-21 10:45:41 UTC 
Review of attachment 281202 [details] [review]:

++
Comment 6 Bastien Nocera 2014-07-21 10:47:19 UTC 
Review of attachment 281219 [details] [review]:

There are already patches for that in bug 731792.

See also bug 732375
Comment 7 Cosimo Cecchi 2014-07-23 03:08:42 UTC 
Attachment 281201 [details] pushed as 8b3a689 - info: use resource instead of pixbuf to load SVG
Attachment 281202 [details] pushed as 059ee0b - mouse: use resource instead of pixbuf to load SVG

OK - I'll close this bug for now and use the others for the background panel fix.