After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733357 - The rendered image sometimes has vertical stripes at the right edge
The rendered image sometimes has vertical stripes at the right edge
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: gegl-gtk
git master
Other All
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2014-07-18 13:55 UTC by Debarshi Ray
Modified: 2015-05-23 20:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use cairo API to calculate stride (1.57 KB, patch)
2014-07-18 13:59 UTC, Debarshi Ray 		committed Details | Review
Fix vertical strips in the rendered image (866 bytes, patch)
2014-07-18 14:00 UTC, Debarshi Ray 		reviewed Details | Review

Description Debarshi Ray 2014-07-18 13:55:03 UTC 
I would like to upstream some fixes from the copy of GeglGtkView that we have in gnome-photos. Admittedly we are using gegl-0.2 because that is what the distributions are carrying, but the fixes are still relevant.

See the screenshot in bug 733355
Comment 1 Debarshi Ray 2014-07-18 13:59:52 UTC 
Created attachment 281100 [details] [review]
Use cairo API to calculate stride
Comment 2 Debarshi Ray 2014-07-18 14:00:49 UTC 
Created attachment 281101 [details] [review]
Fix vertical strips in the rendered image
Comment 3 Jon Nordby 2014-07-18 16:28:00 UTC 
Review of attachment 281101 [details] [review]:

How does the artifacts you see look like?
I expected the gegl_node_blit() below the g_malloc() to fill out the entire buffer that is allocated.
So I'm a bit skeptical of this fix, might be hiding other bugs...
Comment 4 Jon Nordby 2014-07-18 16:28:42 UTC 
Review of attachment 281100 [details] [review]:

Looks good!
Comment 5 Debarshi Ray 2014-07-18 16:53:32 UTC 
Comment on attachment 281100 [details] [review]
Use cairo API to calculate stride

Thanks for the review, Jon.
Comment 6 Øyvind Kolås (pippin) 2015-05-23 10:18:54 UTC 
The patch has already been applied, but the bug lingered open.

commit 5dbb89dc0518efa047595cdb63b0b3265422cd30
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Fri Jul 18 15:57:46 2014 +0200

    Use cairo API to calculate stride (bug 733357)
    
    The cairo documentation recommends this because the stride maybe larger
    than width * bytes_per_pixel to provide proper alignment for each pixel
    and row.
Comment 7 Debarshi Ray 2015-05-23 20:07:28 UTC 
We kept it open for the other patch (attachment 281101 [details] [review]), which actually addresses the vertical stripes. However, Jon might be right about there being other bugs lingering in the code. eg., bug 747446 might be related.