After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733289 - lua-factory: don't iterate on lua env table
lua-factory: don't iterate on lua env table
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
: 733257 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-07-17 04:17 UTC by Victor Toso
Modified: 2014-07-18 02:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
lua-factory: don't iterate on lua env table (1.04 KB, patch)
2014-07-17 04:17 UTC, Victor Toso 		committed Details | Review

Description Victor Toso 2014-07-17 04:17:20 UTC 
fix
Comment 1 Victor Toso 2014-07-17 04:17:22 UTC 
Created attachment 280901 [details] [review]
lua-factory: don't iterate on lua env table

When calling a c function in lua, the top of the stack is the
environment table of lua, _G.

This patch fixes the case where GrlNetWc options was not passed
at grl.fetch and grl.unzip functions.
Comment 2 Bastien Nocera 2014-07-17 09:10:54 UTC 
Review of attachment 280901 [details] [review]:

Looks good.
Comment 3 Bastien Nocera 2014-07-17 09:11:42 UTC 
*** Bug 733257 has been marked as a duplicate of this bug. ***
Comment 4 Victor Toso 2014-07-18 02:47:55 UTC 
Attachment 280901 [details] pushed as 56f5148 - lua-factory: don't iterate on lua env table