After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733162 - [PATCHes] Add command-line options and jumplist.
[PATCHes] Add command-line options and jumplist.
Status: RESOLVED FIXED
Product: gnome-mines
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-mines-maint
gnome-mines-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-14 14:24 UTC by Arnaud B.
Modified: 2014-09-23 18:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove white spaces. (3.52 KB, patch)
2014-07-14 14:24 UTC, Arnaud B.
committed Details | Review
Add --version command-line option. (2.95 KB, patch)
2014-07-14 14:24 UTC, Arnaud B.
committed Details | Review
Update man page. (1008 bytes, patch)
2014-07-14 14:25 UTC, Arnaud B.
committed Details | Review
Add --small, --medium and --big command-line options. (3.04 KB, patch)
2014-07-14 14:27 UTC, Arnaud B.
committed Details | Review
Add jumplist. (812 bytes, patch)
2014-07-14 14:29 UTC, Arnaud B.
committed Details | Review

Description Arnaud B. 2014-07-14 14:24:26 UTC
Created attachment 280643 [details] [review]
Remove white spaces.

Some command-line options should be quite interesting for usual players. Here
are five patches:
* 0001 is just a preliminary cleanup;
* 0002 adds the standard --version, for developpers;
* 0003 corrects the man page;
* 0004 adds --small, --medium and --big, for choosing the board size and launching the game, because beginning with a main screen is not suitable for usual players;
* 0005 adds the Shell’s jumplist with the same options, for the same reasons.
Comment 1 Arnaud B. 2014-07-14 14:24:56 UTC
Created attachment 280644 [details] [review]
Add --version command-line option.
Comment 2 Arnaud B. 2014-07-14 14:25:22 UTC
Created attachment 280645 [details] [review]
Update man page.
Comment 3 Arnaud B. 2014-07-14 14:27:41 UTC
Created attachment 280646 [details] [review]
Add --small, --medium and --big command-line options.

I’m not really fan of having a --custom option (should we in this case offer -x, -y, -n options? that’s many options and nobody will use them…). So just implementing the default sizes.
Comment 4 Arnaud B. 2014-07-14 14:29:05 UTC
Created attachment 280647 [details] [review]
Add jumplist.

Based on --small, --medium and --big command-line options; see explainations about --custom before.
Comment 5 Robert Roth 2014-09-13 17:05:02 UTC
Attachment 280643 [details] pushed as 0d30464 - Remove white spaces.
Attachment 280644 [details] pushed as 3ad0a5e - Add --version command-line option.
Attachment 280645 [details] pushed as 6707dec - Update man page.
Attachment 280647 [details] pushed as 2100f25 - Add jumplist.
Comment 6 Robert Roth 2014-09-13 17:05:45 UTC
Review of attachment 280646 [details] [review]:

Thanks.
Comment 7 Robert Roth 2014-09-13 17:17:52 UTC
Review of attachment 280644 [details] [review]:

Sorry, I did the merges and push in a rush, and forgot that we're in string freeze, so I had to revert most of the commits, setting them to commit after freeze.
Comment 8 Robert Roth 2014-09-13 17:18:12 UTC
Review of attachment 280645 [details] [review]:

Sorry, I did the merges and push in a rush, and forgot that we're in string freeze, so I had to revert most of the commits, setting them to commit after freeze.
Comment 9 Robert Roth 2014-09-13 17:18:18 UTC
Review of attachment 280646 [details] [review]:

Sorry, I did the merges and push in a rush, and forgot that we're in string freeze, so I had to revert most of the commits, setting them to commit after freeze.
Comment 10 Robert Roth 2014-09-13 17:18:28 UTC
Review of attachment 280647 [details] [review]:

Sorry, I did the merges and push in a rush, and forgot that we're in string freeze, so I had to revert most of the commits, setting them to commit after freeze.
Comment 11 Robert Roth 2014-09-13 17:19:21 UTC
Reopening, as most of the patches have been reverted from trunk. We'll have those in the next cycle.
Comment 12 Robert Roth 2014-09-23 18:44:03 UTC
Attachment 280644 [details] pushed as 701f072 - Add --version command-line option.
Attachment 280645 [details] pushed as 551611b - Update man page.
Attachment 280647 [details] pushed as 0c26aad - Add jumplist.
Comment 13 Robert Roth 2014-09-23 18:45:26 UTC
Review of attachment 280646 [details] [review]:

Committed, as 3.14 is out.