After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733123 - mxfmux: Avoid taking unnecessary ref
mxfmux: Avoid taking unnecessary ref
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal minor
: 1.4.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-13 14:14 UTC by Sebastian Rasmussen
Modified: 2014-07-16 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch fixing leak. (807 bytes, patch)
2014-07-13 14:14 UTC, Sebastian Rasmussen 		none Details | Review
Proposed patch fixing leak. (807 bytes, patch)
2014-07-13 14:15 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-07-13 14:14:11 UTC 
gst_pad_get_pad_template() returns a reference that must be freed, but in this instance I think we can simply refer to the template directly.
Comment 1 Sebastian Rasmussen 2014-07-13 14:14:30 UTC 
Created attachment 280585 [details] [review]
Proposed patch fixing leak.
Comment 2 Sebastian Rasmussen 2014-07-13 14:15:16 UTC 
Created attachment 280586 [details] [review]
Proposed patch fixing leak.

Note to self: the commit message is supposed to contain a correct bugzilla bug number!
Comment 3 Sebastian Dröge (slomo) 2014-07-16 14:48:58 UTC 
commit e79e96e59dad6410594a7ae1080c9c4cd8fc5b08
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sun Jul 13 16:07:02 2014 +0200

    mxfmux: Avoid taking unnecessary ref
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=733123