After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733046 - visual: Remove support for < 0.4
visual: Remove support for < 0.4
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.3.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-11 07:34 UTC by Edward Hervey
Modified: 2014-07-11 08:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
visual: Fix usage with < 0.4 (1.40 KB, patch)
2014-07-11 07:34 UTC, Edward Hervey 		rejected Details | Review
libvisual: Remove < 0.4 support (7.69 KB, patch)
2014-07-11 08:13 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2014-07-11 07:34:36 UTC 
Should also fix the build on bsd
Comment 1 Edward Hervey 2014-07-11 07:34:38 UTC 
Created attachment 280473 [details] [review]
visual: Fix usage with < 0.4

This got broken in the baseaudiovisualizer refactoring in
5e6abc449b16ee3b944251728c477347ea34351f

While libvisual 0.2 is 8 years old ... we should still try not to
break it.

Just revert changes, and also apply a cast (to silence clang sign
warnings).
Comment 2 Edward Hervey 2014-07-11 08:08:26 UTC 
After IRC discussions, let's just remove support for < 0.4 (which was released in 2006)
Comment 3 Edward Hervey 2014-07-11 08:13:38 UTC 
Created attachment 280476 [details] [review]
libvisual: Remove < 0.4 support

And remove the version guards that went along with it
Comment 4 Edward Hervey 2014-07-11 08:21:56 UTC 
commit 52b6fb732261f305532bad297658179faf6a7432
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Fri Jul 11 10:13:03 2014 +0200

    libvisual: Remove < 0.4 support
    
    And remove the version guards that went along with it
    
    https://bugzilla.gnome.org/show_bug.cgi?id=733046