After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733012 - playbin: *-filter properties are settable, but not gettable
playbin: *-filter properties are settable, but not gettable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
1.3.90
Other Windows
: Normal normal
: 1.4.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-10 14:54 UTC by brmftwpo
Modified: 2014-07-12 07:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
playsink: Fix filter property getter (1.04 KB, patch)
2014-07-12 05:04 UTC, Arun Raghavan 		committed Details | Review

Description brmftwpo 2014-07-10 14:54:05 UTC 
The playbin's audio-filter and video-filter properties are set by delegating to its playsink element (via gst_play_sink_set_filter()), using the sink_type GST_PLAY_SINK_TYPE_AUDIO/VIDEO. 

However, playsink's gst_play_sink_get_filter() method only checks for the raw types (GST_PLAY_SINK_TYPE_AUDIO_RAW/GST_PLAY_SINK_TYPE_VIDEO_RAW), and since playbin always requests the non-raw type it always returns NULL.

Should playsink be checking for the non-raw types also?
Comment 1 Arun Raghavan 2014-07-12 05:04:44 UTC 
Created attachment 280540 [details] [review]
playsink: Fix filter property getter

The switch-case set was incomplete.
Comment 2 Arun Raghavan 2014-07-12 07:42:08 UTC 
Thank you for the report and the investigation. This will be fixed in the next release.