After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733002 - [review] dcbw/tui-password-fixes: nmtui-edit fails to save wireless psk passphrase
[review] dcbw/tui-password-fixes: nmtui-edit fails to save wireless psk passp...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nmtui
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-10 13:37 UTC by Michael Biebl
Modified: 2014-09-19 18:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Michael Biebl 2014-07-10 13:37:12 UTC 
Version: 0.9.10.0
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754382


nmtui does not save wireless passphrase to profile. Configuration file for
connection doesn't contain 'psk=' line after editing with nmtui.

Editing connection with nmcli was successful, psk can be set and saved.
Comment 1 Michael Biebl 2014-07-10 13:57:32 UTC 
For completeness sake: the connections are stored using the keyfile plugin
Comment 2 Michael Biebl 2014-07-10 15:53:30 UTC 
Additional information: The Wi-Fi connection was created using nmtui-edit.
Here saving the passphrase fails.

When using nmtui-connect to create a new connection, the psk is saved correctly.
Comment 3 Dan Williams 2014-09-03 22:47:09 UTC 
Fixes in dcbw/tui-password-fixes
Comment 4 Dan Winship 2014-09-04 01:14:13 UTC 
> tui: fix requesting and displaying secrets

It leaks the copied secrets now.

But I was thinking, maybe a simpler solution would be to add a public user_data field to NmtSyncOp, and then build_edit_connection() can set that to edit_connection, and then got_secrets() can call nm_connection_update_secrets() itself. Except that now that I look, we'd need to pass both edit_connection AND setting_name so that won't actually work. Meh. OK, so just remember to free the passed-back secrets hash.

The other patch looks right.
Comment 5 Dan Williams 2014-09-04 15:02:02 UTC 
Fixed the leakage and merged to master and nm-0-9-10