After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732936 - "empty location" string not marked for translation
"empty location" string not marked for translation
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: wizard
3.13.x
Other All
: Normal trivial
: 3.22
Assigned To: Lasse Schuirmann
GNOME Boxes maintainer(s)
Depends on: 729026
Blocks:
 
 
Reported: 2014-07-09 06:38 UTC by Lasse Schuirmann
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wizard: Add missing translation mark (1.10 KB, patch)
2014-08-10 12:22 UTC, Lasse Schuirmann 		committed Details | Review

Description Lasse Schuirmann 2014-07-09 06:38:17 UTC 
In src/wizard.vala, prepare_for_location () throws exceptions. These are catched in prepare () and the message is shown to the user. One of these exception messages is not marked for translation.

I'll provide a patch for this when the patches for Bug#729026 are committed so I don't have to rebase it.
Comment 1 Lasse Schuirmann 2014-08-10 12:22:08 UTC 
Created attachment 283032 [details] [review]
wizard: Add missing translation mark

The "Empty location" string in the exception may be shown to the user
in wizard.vala, line 373 and should therefore be translated.
Comment 2 Zeeshan Ali 2014-08-11 14:10:06 UTC 
Review of attachment 283032 [details] [review]:

ack
Comment 3 Zeeshan Ali 2014-08-11 14:12:21 UTC 
Attachment 283032 [details] pushed as 2fed727 - wizard: Add missing translation mark