After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732715 - aiff,mimdec: Print invalid fourcc in error message in hex
aiff,mimdec: Print invalid fourcc in error message in hex
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal minor
: 1.3.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-04 02:13 UTC by Sebastian Rasmussen
Modified: 2014-07-04 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch 1/4. (1.15 KB, patch)
2014-07-04 02:14 UTC, Sebastian Rasmussen 		committed Details | Review
Proposed patch 2/4. (1.21 KB, patch)
2014-07-04 02:14 UTC, Sebastian Rasmussen 		rejected Details | Review
Proposed patch 3/4. (1.03 KB, patch)
2014-07-04 02:15 UTC, Sebastian Rasmussen 		committed Details | Review
Proposed patch 4/4. (1.33 KB, patch)
2014-07-04 02:15 UTC, Sebastian Rasmussen 		rejected Details | Review

Description Sebastian Rasmussen 2014-07-04 02:13:43 UTC 
Inspired by the bugs I found in
https://bugzilla.gnome.org/show_bug.cgi?id=732697 I looked for further
omissions and found them in various elements.

I couldn't find a good way of combining these commits due to limitations in the commit summary message. But if you do, please feel free to squash into a single one or something like that. :)
Comment 1 Sebastian Rasmussen 2014-07-04 02:14:45 UTC 
Created attachment 279872 [details] [review]
Proposed patch 1/4.
Comment 2 Sebastian Rasmussen 2014-07-04 02:14:58 UTC 
Created attachment 279873 [details] [review]
Proposed patch 2/4.
Comment 3 Sebastian Rasmussen 2014-07-04 02:15:12 UTC 
Created attachment 279874 [details] [review]
Proposed patch 3/4.
Comment 4 Sebastian Rasmussen 2014-07-04 02:15:26 UTC 
Created attachment 279875 [details] [review]
Proposed patch 4/4.
Comment 5 Sebastian Rasmussen 2014-07-04 02:16:25 UTC 
(In reply to comment #2)

Oh, and yes I did notice that sdlvideosink has not been ported yet, but that doesn't mean it never will so we'd better fix bugs there too, no..?
Comment 6 Tim-Philipp Müller 2014-07-04 08:17:42 UTC 
I think this only needs fixing where there might actually be non-ASCII fourccs, so don't know if we need to worry about uvch264src or sdlvideosink (and I'd prefer not to patch non-ported code). AIFF - ok, mimdec - ok.
Comment 7 Tim-Philipp Müller 2014-07-04 16:51:27 UTC 
Comment on attachment 279873 [details] [review]
Proposed patch 2/4.

not ported yet and I think the fourccs will always be sane here.
Comment 8 Tim-Philipp Müller 2014-07-04 16:51:41 UTC 
Comment on attachment 279875 [details] [review]
Proposed patch 4/4.

I think the fourccs are likely to be always sane here.
Comment 9 Tim-Philipp Müller 2014-07-04 16:52:33 UTC 
commit 77905f632e3bb65ece1e214d6a4e8935697c4caa
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Fri Jul 4 03:19:42 2014 +0200

    mimdec: Print invalid fourcc in error message in hex
    
    Previously this was printed as characters which caused later processing
    of the error message to sometimes warn about non-UTF-8 characters.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=732715

commit 1f371ce8558fd5fb47fc766e32b5c3ead1134fa4
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Fri Jul 4 03:20:22 2014 +0200

    aiffparse: Print invalid fourcc in error message in hex
    
    Previously this was printed as characters which caused later processing
    of the error message to sometimes warn about non-UTF-8 characters.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=732715