GNOME Bugzilla – Bug 732662
glmixer didn't receive the GstGLContext from downstream basetransform
Last modified: 2014-08-11 13:40:24 UTC
I found this commit e1e2a88358c6aeba220d20ed9ff32af141cb2575 glmixer: send the stream-start event and the caps event after. cause black screen if glvideomixer is not the last element before glimagesink pipeline constructed as videotestsrc ! glvideomixer ! glfilterblur ! glimagesink glmixer didn't got GstGLContext , then created a GstGLContext itself. but if pipeline constructed as videotestsrc ! glfilterblur ! glvideomixer ! glimagesink everything seems OK
Right so it would seem that glvideomixer does an allocation query before videoaggregator has sent the caps event and so basetransform replies that it can't answer the allocation query yet (because it is not fully negotiated). Thus no GL context sharing between elements.
Created attachment 282764 [details] [review] videoaggregator: don't delay the caps event This fixes the issue for me. I'm not sure about its correctness though.
Review of attachment 282764 [details] [review]: Just change that doc and push please. ::: gst-libs/gst/base/gstaggregator.c @@ +341,3 @@ + * gst_aggregator_set_src_caps: + * @self: The #GstAggregator + * @caps: The #GstCaps to set later on the src pad. Please remove the "later" part :)
commit 7c016752d7b96f12d010134c606c0d587ad3534e Author: Matthew Waters <ystreet00@gmail.com> Date: Thu Aug 7 19:54:36 2014 +1000 videoaggregator: push the caps event as soon as we receive it Along with the required mandatory dependent events. Some elements need to perform an allocation query inside ::negotiated_caps(). Without the caps event being sent prior, downstream elements will be unable to answer and will return an error. https://bugzilla.gnome.org/show_bug.cgi?id=732662 commit 44e84025d7d004276bb53a5485442ff9734dcfd2 Author: Matthew Waters <ystreet00@gmail.com> Date: Mon Aug 11 23:38:40 2014 +1000 aggregator: fix up doc comment for set_src_caps It does not occur 'later' anymore https://bugzilla.gnome.org/show_bug.cgi?id=732662