GNOME Bugzilla – Bug 732566
Encrypted partition created if passphrase was entered on Create Partition dialog despite switching back to unencrypted partition
Last modified: 2017-04-04 11:55:19 UTC
Created attachment 279703 [details] screencast demonstrating bug * Open the Create Partition dialog * Under Type, select Encrypted Partition * Enter a passphrase * Change your mind and change the Type to ext4 * Click create Expected: gnome-disks creates an ext4 partition Actual: gnome-disks creates an encrypted partition
Patch pending, soon to be resolved.
Created attachment 349164 [details] [review] Fix wrong behavior of filesystem creation dialog by adding an "encrypted" property
Review of attachment 349164 [details] [review]: Thanks for your patch. The patch seems work nicely, but wouldn't be better to just simply clear the password entries if LUKS is not selected?
Ideally I think the format dialog should be reworked anyway and the encrypt option split to be separate from the filesystem selection. So if now a solution clears the passphrase at each selected filesystem option except LUKS+ext4 this would need to be changed again later.
Created attachment 349198 [details] [review] Fix wrong behavior of filesystem creation dialog by adding an "encrypted" property (added bugzilla link to commit message)
Thanks for your contribution! I have pushed the Attachment 349198 [details] as d4695b9. I have just modified the short commit description to be shorter (it should be up to 50 chars at the best as per guidelines)...
(In reply to Kai Lüke from comment #4) > Ideally I think the format dialog should be reworked anyway and the encrypt > option split to be separate from the filesystem selection. So if now a > solution clears the passphrase at each selected filesystem option except > LUKS+ext4 this would need to be changed again later. It is ok if you have some future plans with it... (In reply to Kai Lüke from comment #5) > Created attachment 349198 [details] [review] [review] > Fix wrong behavior of filesystem creation dialog by adding an "encrypted" > property > > (added bugzilla link to commit message) I really appreciate that you updated this patch as per my comment from another bug :-)