After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732361 - Drop default values for check buttons from ui file
Drop default values for check buttons from ui file
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-27 20:04 UTC by Matthias Clasen
Modified: 2014-07-08 15:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Drop default values for check buttons from ui file (8.28 KB, patch)
2014-06-27 20:04 UTC, Matthias Clasen
none Details | Review
profile: Drop default values for check buttons (8.40 KB, patch)
2014-07-08 13:38 UTC, Debarshi Ray
committed Details | Review

Description Matthias Clasen 2014-06-27 20:04:18 UTC
Setting an xalign of 0.5 and expecting the following setting
of draw-indicator to TRUE to neutralize it is somewhat fragile.
It only worked because GTK+ was doing redundant property
notification.

Now that GTK+ uses G_PARAM_EXPLICIT_NOTIFY, it no longer works.
Comment 1 Matthias Clasen 2014-06-27 20:04:26 UTC
Created attachment 279440 [details] [review]
Drop default values for check buttons from ui file
Comment 2 Matthias Clasen 2014-06-28 23:17:27 UTC
this has been worked around in gtk for now.
Comment 3 Christian Persch 2014-06-30 09:20:33 UTC
Ok, so let's defer this until after bug 724110 since merge conflicts in glade are so ugly to handle :-)
Comment 4 Debarshi Ray 2014-07-08 13:38:43 UTC
Created attachment 280156 [details] [review]
profile: Drop default values for check buttons

Rebased against master.