After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732178 - glcolorscale: add support for passthrough on same caps
glcolorscale: add support for passthrough on same caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.3.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 730928
 
 
Reported: 2014-06-24 18:34 UTC by Julien Isorce
Modified: 2014-07-02 04:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
glfilter: prepend intersection to src caps (1.05 KB, patch)
2014-06-24 18:40 UTC, Julien Isorce
committed Details | Review
glfilter: handle NULL decide_query which means passthrough (1.61 KB, patch)
2014-06-24 18:40 UTC, Julien Isorce
committed Details | Review
glcolorscale: do passthrough on same caps (1.09 KB, patch)
2014-06-24 18:41 UTC, Julien Isorce
committed Details | Review

Description Julien Isorce 2014-06-24 18:34:31 UTC
Currently decoder ! video/x-raw(memory:EGLImage) ! glcolorscale ! fakesink makes it output GLMemory whereas glcolorscale should enter in passthrough.

It's useful for an application to set "glcolorscale ! appsink" as the videosink to let glcolorscale handles the propose_allocation and the gl buffer pool.
Comment 1 Julien Isorce 2014-06-24 18:40:02 UTC
Created attachment 279140 [details] [review]
glfilter: prepend intersection to src caps
Comment 2 Julien Isorce 2014-06-24 18:40:36 UTC
Created attachment 279141 [details] [review]
glfilter: handle NULL decide_query which means passthrough
Comment 3 Julien Isorce 2014-06-24 18:41:16 UTC
Created attachment 279142 [details] [review]
glcolorscale: do passthrough on same caps
Comment 4 Matthew Waters (ystreet00) 2014-06-24 23:56:49 UTC
Review of attachment 279140 [details] [review]:

Looks good
Comment 5 Matthew Waters (ystreet00) 2014-06-24 23:57:20 UTC
Review of attachment 279141 [details] [review]:

Looks good
Comment 6 Matthew Waters (ystreet00) 2014-06-24 23:57:53 UTC
Review of attachment 279142 [details] [review]:

Looks good
Comment 7 Julien Isorce 2014-06-25 06:48:07 UTC
commit 13023f297507cf503e758271ce0797e22e5f92ae
Author: Julien Isorce <julien.isorce@collabora.co.uk>
Date:   Tue Jun 24 19:37:17 2014 +0100

    glcolorscale: do passthrough on same caps
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=732178

commit f63c91ab714ec145e43fb1ddb76368a7d2fff5db
Author: Julien Isorce <julien.isorce@collabora.co.uk>
Date:   Tue Jun 24 19:35:01 2014 +0100

    glfilter: handle NULL decide_query which means passthrough
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=732178

commit 045aa4ee7ec58450db4b0cfd8153fafcc4d456d3
Author: Julien Isorce <julien.isorce@collabora.co.uk>
Date:   Tue Jun 24 19:23:01 2014 +0100

    glfilter: prepend intersection to src caps
    
    Prefer to stay in the same memory space if possible.
    Also it let a chance to do passthrough.
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=732178