GNOME Bugzilla – Bug 732103
More discoverable/easy to access bookmark action
Last modified: 2016-03-03 08:29:41 UTC
In recent user tests, bookmarking in Nautilus performed rather badly. Things that happened with a sizeable proportion of test participants: * They struggled to find the bookmark action. * They found Make Link instead, and thought it was the same as creating a bookmark. * Those with Windows experience tried to drag locations onto the desktop. There are a few things we can do to address this: * Add a Bookmark action to context menus for folders. * When dragging a folder, show a "Create Bookmark" drop target in the sidebar. * Move the Make Link option into an extension. Regarding the last item, bookmarks are much more effective as a way to create navigation points, and having both Make Link and Bookmark next to each other would be pretty confusing.
No idea how I filed this against the wrong app...!
(In reply to comment #0) > [snip] > > * When dragging a folder, show a "Create Bookmark" drop target in the sidebar. > That exists already. The problem is that you need to have at least one bookmark already set (so Bookmarks section is shown) for the "New Bookmark" to appear when you DND over the Bookmarks section. That bug was filed as bug 712790 . Another improvement would be that "New Bookmark" appeared when you DND over *anywhere* on the sidebar, currently it only appears when you hover over the Bookmarks section.
(In reply to comment #2) ... > > * When dragging a folder, show a "Create Bookmark" drop target in the sidebar. > > > > That exists already. The problem is that you need to have at least one bookmark > already set (so Bookmarks section is shown) for the "New Bookmark" to appear > when you DND over the Bookmarks section. That bug was filed as bug 712790 . It's still not a clearly advertised drop target. > Another improvement would be that "New Bookmark" appeared when you DND over > *anywhere* on the sidebar, currently it only appears when you hover over the > Bookmarks section. My proposal was to show the bookmarks drop target whenever you are dragging a folder, irrespective of where the pointer is - so I think it covers this.
> My proposal was to show the bookmarks drop target whenever you are dragging a > folder, irrespective of where the pointer is - so I think it covers this. I agree that having "New Bookmark" appear as an option would help users to create bookmarks.
3.14 is over - move to the 3.16 target milestone.
Created attachment 298831 [details] [review] view: new add bookmark selection menu item This patch introduces a new "Add Bookmark" context menu item when the the selection is constituted only by folders. When file is present, the item is not shown. Note that, when multiple folders are selected at the same time, all of them are added to the bookmark list. This patch also fixes a small memory leak present at NautilusView::real_update_actions_state where the list and it's counter were being assigned twice, whereas only the second was freed.
Created attachment 298833 [details] [review] view: new add bookmark selection menu item Actually, the list wasn't freed at all. This updated patch fixes it.
Created attachment 298838 [details] [review] view: new add bookmark selection menu item Another unfreed list issue fixed.
Review of attachment 298833 [details] [review]: commit message nit picks: when AAA file is present. Code Wise: For the memory leak, make another patch that comes before this one, since it has nothing to do with what this patch is doing. You are adding a bookmark action to the view. But we kind of hace one in the window. I don't like to be in the window, but I didn't have enough reasons before to change it's location. Now we have a reason, having all the bookmark managament in the view. Could you make a "before patch" moving the window bookmark-location action to the view? So this patch will be in the correct location automatically. ::: src/nautilus-view-context-menus.xml @@ +144,3 @@ + <attribute name="hidden-when">action-disabled</attribute> + </item> + <item> I would put it in its own section. Let's see what designers say. For me it will look odd in any part I think... =( Also, when you move the bookmark-location from the window, you can add as well "Add _Bookmark" for the background menu. ::: src/nautilus-view.c @@ +5393,2 @@ static void +action_bookmark_location (GSimpleAction *action, bookmark location, but we are bookmarking all the selection. action_bookmark_selection and bookmark-selection. @@ +5407,3 @@ + NautilusBookmark *bookmark; + NautilusFile *file; + GFile *loc; location. Not need to simplify here. @@ +5948,3 @@ selection_all_in_trash = all_in_trash (selection); + show_bookmark = selection_count > 0 && all_directories (selection); you need nautilus_bookmark_list_can_bookmark_location () as well @@ +6205,3 @@ nautilus_view_supports_zooming (view)); + + nautilus_file_list_free (selection); different patch
I think the nautilus context menu is already overlong. Adding "Add Bookmarks" there makes that problem worse, and does not really help with the discoverability of bookmarking either...
(In reply to Matthias Clasen from comment #10) > I think the nautilus context menu is already overlong. This is something I agree. Maybe we should find a way to simplify Nautilus context menu, or abbandon this "Add Bookmarks" item at all.
I've filed bug 747641 for the GtkPlacesSidebar part of this.
What if we completely dropped the context menu and go for Action Bars? We could use a [non-starred-symbolic] button just like gnome-photos to Add the current open folder to the bookmarks list on the sidebar.
->3.18 and figure a better way in general
Sidebar done, left items is the bookmark context menu item, but we are unsure about that. Move to 3.20 and decide something.
Action bar is considered for 3.22, that might help here. Moving milestone for leftover items.
Allan, do we still want the Add Bookmark as a context menu?
(In reply to Carlos Soriano from comment #17) > Allan, do we still want the Add Bookmark as a context menu? That context menu seems rather long to me - it might be a bit much to add another item. Maybe we can leave this part.
I'm going to close the bug as fixed then. Feel free to reopen if we change our mind. Thanks Georges for the patch!