GNOME Bugzilla – Bug 732102
GSettings: try to remove deprecated "schema" property
Last modified: 2014-06-24 21:39:28 UTC
Got another complaint today about the lack of g_settings_get_schema() and it made me think that three years was long enough to wait for this...
Created attachment 278998 [details] [review] gsettings test: stop testing long-deprecated API We want to try taking this away now...
Created attachment 278999 [details] [review] gsettings: remove long-deprecated "schema" property This property has been deprecated for three years after only having existed for one. We've wanted to reuse the name for all that time, so let's try to actually remove it now and see if we can get away with it.
Attachment 278998 [details] pushed as f2ceb74 - gsettings test: stop testing long-deprecated API Attachment 278999 [details] pushed as cf9b162 - gsettings: remove long-deprecated "schema" property
Did you get review from someone else for this? I know you wrote the API, but... This definitely broke gnome-shell, see: https://git.gnome.org/browse/gnome-shell/commit/?id=83cb26d70eac7b3b974948fac0495951d4c200a1 Which was detected by Continuous: http://build.gnome.org/continuous/buildmaster/builds/2014/06/24/48/smoketest/work-gnome-continuous-x86_64-runtime/journal.txt Even if we fix up the components in GNOME, I as a downstream consumer of GLib would like the ability to rebase on newer versions of GLib without changing consuming products such as GTK+ and GNOME. Can this be reverted for the next few years at least? We can revisit deleting it if there's a burning need once GNOME is known fixed and stable fixed versions have propagated out to LTS distributions.
(In reply to comment #4) > Did you get review from someone else for this? I know you wrote the API, > but... Yes. Lars reviewed it but I told him to hold off on the a-c_n because I wanted to give others at least a day to chime in... > Even if we fix up the components in GNOME, I as a downstream consumer of GLib > would like the ability to rebase on newer versions of GLib without changing > consuming products such as GTK+ and GNOME. That's fair -- I didn't realise that use of this was as wide spread. I think we need to increase the "volume level" associated with using deprecated properties. Maybe a runtime g_warning(), enabled by default. > Can this be reverted for the next few years at least? We can revisit deleting > it if there's a burning need once GNOME is known fixed and stable fixed > versions have propagated out to LTS distributions. Sure -- but not before we add the warning... I'll look into that now.
Created attachment 279149 [details] [review] Revert "gsettings: remove long-deprecated "schema" property" This reverts commit cf9b162e0d0defaff2ad5c85aeaf7af0899ad22f. It turns out that there are still a very large number of users of this API.
Attachment 279149 [details] pushed as 59c9291 - Revert "gsettings: remove long-deprecated "schema" property" So we can't do this for now...
Review of attachment 279149 [details] [review]: Yep, thanks.