After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732068 - gsignal: Add an example to the g_signal_connect_swapped() documentation
gsignal: Add an example to the g_signal_connect_swapped() documentation
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-06-23 00:00 UTC by Philip Withnall
Modified: 2014-06-23 11:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gsignal: Add an example to the g_signal_connect_swapped() documentation (2.36 KB, patch)
2014-06-23 00:00 UTC, Philip Withnall 		reviewed Details | Review
gsignal: Add an example to the g_signal_connect_swapped() documentation (2.40 KB, patch)
2014-06-23 11:31 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2014-06-23 00:00:30 UTC 
Patch attached.
Comment 1 Philip Withnall 2014-06-23 00:00:32 UTC 
Created attachment 278963 [details] [review]
gsignal: Add an example to the g_signal_connect_swapped() documentation

The precise behaviour of and motivation behind swapping parameters was
not entirely clear before.
Comment 2 Emmanuele Bassi (:ebassi) 2014-06-23 10:59:14 UTC 
Review of attachment 278963 [details] [review]:

looks good to me, apart from a couple of doc issues.

::: gobject/gsignal.h
@@ +501,3 @@
+ *
+ * For example, this allows the shorter code:
+ * |[

you should add a `<!-- language="C" -->` annotation to the code example.

@@ +507,3 @@
+ *
+ * Rather than the cumbersome:
+ * |[

same as above.
Comment 3 Philip Withnall 2014-06-23 11:31:13 UTC 
Created attachment 278989 [details] [review]
gsignal: Add an example to the g_signal_connect_swapped() documentation

The precise behaviour of and motivation behind swapping parameters was
not entirely clear before.
Comment 4 Philip Withnall 2014-06-23 11:32:11 UTC 
Pushed with the language tag additions.

Attachment 278989 [details] pushed as 248ca72 - gsignal: Add an example to the g_signal_connect_swapped() documentation