GNOME Bugzilla – Bug 731981
libebook: Don’t warn on calling unimplemented methods
Last modified: 2014-06-20 19:43:23 UTC
Patch coming.
Created attachment 278858 [details] [review] libebook: Don’t warn on calling unimplemented methods If a warning is needed, it should be in the method itself. Otherwise we can be outputting spurious warnings for methods which don’t need implementing. This fixes the libfolks EDS tests.
Looks okay to me. Can you also make an equivalent change to ECalClientView, since we still don't have a common base class?
Created attachment 278865 [details] [review] libecal: Don’t warn on calling unimplemented methods See commit d1f237c2e455dda7c91ca79a6f643ef1a613bb61 for rationale.
commit 79d3746656bf07fedfc4ec092e24ce3fb70bf651 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Fri Jun 20 20:40:55 2014 +0100 libecal: Don’t warn on calling unimplemented methods See commit d1f237c2e455dda7c91ca79a6f643ef1a613bb61 for rationale. https://bugzilla.gnome.org/show_bug.cgi?id=731981 calendar/libecal/e-cal-client-view.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit d1f237c2e455dda7c91ca79a6f643ef1a613bb61 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Fri Jun 20 19:09:45 2014 +0100 libebook: Don’t warn on calling unimplemented methods If a warning is needed, it should be in the method itself. Otherwise we can be outputting spurious warnings for methods which don’t need implementing. This fixes the libfolks EDS tests. https://bugzilla.gnome.org/show_bug.cgi?id=731981 addressbook/libebook/e-book-client-view.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)