After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731880 - Set the cancellable to check on each GSimpleAsyncResult
Set the cancellable to check on each GSimpleAsyncResult
Status: RESOLVED FIXED
Product: geocode-glib
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: geocode-glib maintainer(s)
geocode-glib maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-06-18 20:01 UTC by Giovanni Campagna
Modified: 2014-06-18 20:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Set the cancellable to check on each GSimpleAsyncResult (1.46 KB, patch)
2014-06-18 20:01 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2014-06-18 20:01:03 UTC
This provides the expected semantics that cancelling an async call
trumps on any successful result or previous error.
Comment 1 Giovanni Campagna 2014-06-18 20:01:06 UTC
Created attachment 278713 [details] [review]
Set the cancellable to check on each GSimpleAsyncResult
Comment 2 Zeeshan Ali 2014-06-18 20:14:08 UTC
Review of attachment 278713 [details] [review]:

ACK
Comment 3 Giovanni Campagna 2014-06-18 20:14:59 UTC
Attachment 278713 [details] pushed as 6fa239b - Set the cancellable to check on each GSimpleAsyncResult