After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731834 - GtkPopover is referenced directly in theme css
GtkPopover is referenced directly in theme css
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-06-18 11:31 UTC by Lars Karlitski
Modified: 2014-06-18 12:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkpopover: set background and popover css classes (1.52 KB, patch)
2014-06-18 11:31 UTC, Lars Karlitski 		committed Details | Review
themes: use .popover class instead of GtkPopover (10.30 KB, patch)
2014-06-18 11:31 UTC, Lars Karlitski 		committed Details | Review

Description Lars Karlitski 2014-06-18 11:31:32 UTC 
We consider referencing widget names in css to be bad practice.

As discussed on IRC, GtkPopover should set .background and .popover classes.
Comment 1 Lars Karlitski 2014-06-18 11:31:34 UTC 
Created attachment 278666 [details] [review]
gtkpopover: set background and popover css classes
Comment 2 Lars Karlitski 2014-06-18 11:31:40 UTC 
Created attachment 278667 [details] [review]
themes: use .popover class instead of GtkPopover
Comment 3 Matthias Clasen 2014-06-18 11:45:57 UTC 
Review of attachment 278666 [details] [review]:

Looks good to me
Comment 4 Matthias Clasen 2014-06-18 11:46:09 UTC 
Review of attachment 278667 [details] [review]:

sure
Comment 5 Lars Karlitski 2014-06-18 12:27:12 UTC 
Thanks.