After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731719 - appdata: Add copyright notice and update license fields.
appdata: Add copyright notice and update license fields.
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-06-16 12:25 UTC by Pranav Kant
Modified: 2014-07-11 08:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
appdata: Add copyright notice and update license fields. (2.02 KB, patch)
2014-06-16 12:25 UTC, Pranav Kant
accepted-commit_now Details | Review
appdata: Add copyright notice and update license fields (1.06 KB, patch)
2014-07-11 08:29 UTC, Debarshi Ray
committed Details | Review

Comment 1 Pranav Kant 2014-06-16 12:25:32 UTC
Created attachment 278535 [details] [review]
appdata: Add copyright notice and update license fields.
Comment 2 Cosimo Cecchi 2014-06-16 18:31:52 UTC
Review of attachment 278535 [details] [review]:

Looks good
Comment 3 Debarshi Ray 2014-07-11 08:16:13 UTC
Review of attachment 278535 [details] [review]:

::: data/org.gnome.Documents.appdata.xml.in
@@ +6,3 @@
+  <project_license>GPL-2.0+</project_license>
+  <name>Documents</name>
+  <summary>A document manager application for GNOME</summary>

Dropping the underscore will unmark these strings for translation, no?
Comment 4 Debarshi Ray 2014-07-11 08:29:33 UTC
Created attachment 280477 [details] [review]
appdata: Add copyright notice and update license fields

Retain the underscores which were added in:

commit 79cfb045395e305967f602ef544f25973e5b4033
Author: Richard Hughes <richard@hughsie.com>
Date:   Tue Sep 24 12:56:50 2013 +0100

    Mark the AppData name and summary to be translatable