GNOME Bugzilla – Bug 731715
Encoding: Add support for per slice based handling of packed raw data and packed slice header
Last modified: 2014-06-17 14:07:26 UTC
Created attachment 278528 [details] [review] Add infrastructure for per slice based handling of packed raw data and packed slice header The packed slice headers and packed raw data are needs to be handled in per slice based instead of per frame based.
Created attachment 278529 [details] [review] enc: h264: Fix multiple slice per frame encoding for packed header mode
Review of attachment 278528 [details] [review]: LGTM ::: gst-libs/gst/vaapi/gstvaapiencoder_objects.c @@ +472,3 @@ for (i = 0; i < picture->slices->len; i++) { GstVaapiEncSlice *const slice = g_ptr_array_index (picture->slices, i); + guint j = 0; no need to initialize j here, this is done just below. Fixed locally. :)
Review of attachment 278529 [details] [review]: LGTM. Thanks.
commit 781abad2c7730bddc4ccc2b4fc837d42c2881248 Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Date: Thu Jun 5 15:32:29 2014 +0300 encoder: h264: fix multiple slices support in packed headers mode. Handle packedi slice headers and packed raw data on a per-slice basis, which is necessary for multi slice encoding. commit 786b68ac21a919db59a3dc73b00be37d133b2d39 Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Date: Thu Jun 5 15:30:38 2014 +0300 encoder: add infrastructure for per-slice handling of packed headers. The packed slice header and packed raw data need to be paired with the submission of VAEncSliceHeaderParameterBuffer. So handle them on a per-slice basis insted of a per-picture basis. [removed useless initializer] Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>