After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731714 - gstsrtpenc: add allow-repeat-tx property
gstsrtpenc: add allow-repeat-tx property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.3.2
Other Linux
: Normal enhancement
: 1.3.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-06-16 10:43 UTC by Miguel París Díaz
Modified: 2014-06-18 13:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch (3.29 KB, patch)
2014-06-16 10:43 UTC, Miguel París Díaz 		committed Details | Review

Description Miguel París Díaz 2014-06-16 10:43:09 UTC 
This patch allows retransmitting RTP package using rtprtxqueue
Comment 1 Miguel París Díaz 2014-06-16 10:43:48 UTC 
Created attachment 278526 [details] [review]
The patch
Comment 2 Olivier Crête 2014-06-16 20:00:05 UTC 
You shouldn't do that. You should use rtxsend and rtxreceive which implement RFC 4588 retransmissions. Re-sending the exact same SRTP packet will triggered replay-attack prevent mechanisms, etc.
Comment 3 Miguel París Díaz 2014-06-16 21:13:33 UTC 
I partly agree with you.
I know rtxsend and rtxrecevie, but RFC 4588 is not implemented in some systems and rtprtxqueue is useful for these cases.
I agree with you that allow-repeat-tx can provoque the type of issues that you say, but the developer should know them if he sets this property to TRUE (by default is FALSE). In other words, if libsrtp offers this option, why not the gstsrtpenc element?
Comment 4 Olivier Crête 2014-06-16 21:27:10 UTC 
I guess we could add it with a big warning.
Comment 5 Miguel París Díaz 2014-06-16 21:44:04 UTC 
From my point of view, the most important thing is having a good doc about this feature. It can be based on the libsrtp one (http://srtp.sourcearchive.com/documentation/1.4.4plus-p20100615~dfsg-1build1/structsrtp__policy__t_ae94fa8f82655478e64281692e2fc5213.html)
Comment 6 Wim Taymans 2014-06-18 13:38:51 UTC 
commit 52d4b7de076f5b964ca5dfb904b9bf8408781f29
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Wed Jun 18 15:36:09 2014 +0200

    srtpenc: improve property comments
    
    Add a Note to the allow-repeat-tx property because it is potentially
    insecure when used incorrectly.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=731714