After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 731614 - Ensure that mouse and keyboard events reach the WebKit inspector
Ensure that mouse and keyboard events reach the WebKit inspector
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-06-13 12:25 UTC by Debarshi Ray
Modified: 2014-06-13 14:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
oauth, oauth2: Remove modality from refresh dialogs for the inspector (2.44 KB, patch)
2014-06-13 12:34 UTC, Debarshi Ray 		none Details | Review
webview: Ensure that mouse and keyboard events reach the inspector (1.36 KB, patch)
2014-06-13 14:52 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-06-13 12:25:31 UTC 
I had to use the WebKit inspector while debugging why the Foursquare (bug 729837) log in field is not getting pre-filled. Since this is one of the common reasons for using the inspector, lets remove the modality so things actually work.

Ofcourse, if you are trying to debug addition of new accounts you will still have to remove the modality from the gnome-control-center dialog.
Comment 1 Debarshi Ray 2014-06-13 12:34:19 UTC 
Created attachment 278395 [details] [review]
oauth, oauth2: Remove modality from refresh dialogs for the inspector
Comment 2 Debarshi Ray 2014-06-13 14:50:15 UTC 
Removing the modality won't help. We need to use a separate GtkWindowGroup for the inspector window.
Comment 3 Debarshi Ray 2014-06-13 14:52:02 UTC 
Created attachment 278416 [details] [review]
webview: Ensure that mouse and keyboard events reach the inspector
Comment 4 Debarshi Ray 2014-06-13 14:52:47 UTC 
(In reply to comment #2)
> Removing the modality won't help. We need to use a separate GtkWindowGroup for
> the inspector window.

... because we are using gtk_dialog_run with the dialog that contains the webview.
Comment 5 Debarshi Ray 2014-06-13 14:55:09 UTC 
Review of attachment 278416 [details] [review]:

Committed.